aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFrédéric Buclin <LpSolit@gmail.com>2014-12-17 20:42:10 +0100
committerFrédéric Buclin <LpSolit@gmail.com>2014-12-17 20:42:10 +0100
commit4dba1879f9f70c334ee6a1ba6a992d4aea9232fd (patch)
treee02ff8622e20d99f66308a1808d49bd7e809e5cb
parentBug 1101151: OS sniffing should detect Windows 10 from "Windows NT 6.4" inste... (diff)
downloadbugzilla-4dba1879f9f70c334ee6a1ba6a992d4aea9232fd.tar.gz
bugzilla-4dba1879f9f70c334ee6a1ba6a992d4aea9232fd.tar.bz2
bugzilla-4dba1879f9f70c334ee6a1ba6a992d4aea9232fd.zip
Bug 1111043: Bug.add_comment returns the wrong comment ID
r/a=dkl
-rw-r--r--Bugzilla/WebService/Bug.pm15
1 files changed, 3 insertions, 12 deletions
diff --git a/Bugzilla/WebService/Bug.pm b/Bugzilla/WebService/Bug.pm
index 670d234ce..7dedc5bad 100644
--- a/Bugzilla/WebService/Bug.pm
+++ b/Bugzilla/WebService/Bug.pm
@@ -707,19 +707,10 @@ sub add_comment {
# Append comment
$bug->add_comment($comment, { isprivate => $params->{is_private},
work_time => $params->{work_time} });
-
- # Capture the call to bug->update (which creates the new comment) in
- # a transaction so we're sure to get the correct comment_id.
-
- my $dbh = Bugzilla->dbh;
- $dbh->bz_start_transaction();
-
$bug->update();
-
- my $new_comment_id = $dbh->bz_last_key('longdescs', 'comment_id');
-
- $dbh->bz_commit_transaction();
-
+
+ my $new_comment_id = $bug->{added_comments}[0]->id;
+
# Send mail.
Bugzilla::BugMail::Send($bug->bug_id, { changer => $user });