aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorlpsolit%gmail.com <>2005-06-21 03:22:36 +0000
committerlpsolit%gmail.com <>2005-06-21 03:22:36 +0000
commit7b043a40aa3b90ce29855a5a23bebc49cb8cf5c9 (patch)
tree9cfb4a374742c72384b45f65a851013ea55b31e7 /process_bug.cgi
parentBug 297794: initBug's verification of user_id being an email is bogus - Patch... (diff)
downloadbugzilla-7b043a40aa3b90ce29855a5a23bebc49cb8cf5c9.tar.gz
bugzilla-7b043a40aa3b90ce29855a5a23bebc49cb8cf5c9.tar.bz2
bugzilla-7b043a40aa3b90ce29855a5a23bebc49cb8cf5c9.zip
Bug 298196: process_bug.cgi updates delta_ts even when no modifications are made - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
Diffstat (limited to 'process_bug.cgi')
-rwxr-xr-xprocess_bug.cgi7
1 files changed, 3 insertions, 4 deletions
diff --git a/process_bug.cgi b/process_bug.cgi
index d97474863..c90ed42d9 100755
--- a/process_bug.cgi
+++ b/process_bug.cgi
@@ -1444,9 +1444,8 @@ foreach my $id (@idlist) {
while (MoreSQLData()) {
push(@list, FetchOneColumn());
}
- SendSQL("UPDATE bugs SET delta_ts = $sql_timestamp, keywords = " .
- SqlQuote(join(', ', @list)) .
- " WHERE bug_id = $id");
+ $dbh->do("UPDATE bugs SET keywords = ? WHERE bug_id = ?",
+ undef, join(', ', @list), $id);
}
}
my $query = "$basequery\nwhere bug_id = $id";
@@ -1735,7 +1734,7 @@ foreach my $id (@idlist) {
$i = 0;
foreach my $col (@::log_columns) {
# Consider NULL db entries to be equivalent to the empty string
- $newvalues[$i] ||= '';
+ $newvalues[$i] = defined($newvalues[$i]) ? $newvalues[$i] : '';
# Convert the deadline to the YYYY-MM-DD format.
if ($col eq 'deadline') {
$newvalues[$i] = format_time($newvalues[$i], "%Y-%m-%d");