diff options
author | 2020-05-27 11:26:03 -0400 | |
---|---|---|
committer | 2020-05-27 11:26:03 -0400 | |
commit | 27728be6c304d96b167f86c2c5fa4a154c784da2 (patch) | |
tree | 252d7496a8d6fcc84cc9ca1b64e86e9bac0e6e51 | |
parent | Linux patch 4.9.224 (diff) | |
download | linux-patches-27728be6c304d96b167f86c2c5fa4a154c784da2.tar.gz linux-patches-27728be6c304d96b167f86c2c5fa4a154c784da2.tar.bz2 linux-patches-27728be6c304d96b167f86c2c5fa4a154c784da2.zip |
Linux patch 4.9.2254.9-229
Signed-off-by: Mike Pagano <mpagano@gentoo.org>
-rw-r--r-- | 0000_README | 4 | ||||
-rw-r--r-- | 1224_linux-4.9.225.patch | 3057 |
2 files changed, 3061 insertions, 0 deletions
diff --git a/0000_README b/0000_README index c199ad4e..ae2c4f5b 100644 --- a/0000_README +++ b/0000_README @@ -939,6 +939,10 @@ Patch: 1223_linux-4.9.224.patch From: http://www.kernel.org Desc: Linux 4.9.224 +Patch: 1224_linux-4.9.225.patch +From: http://www.kernel.org +Desc: Linux 4.9.225 + Patch: 1500_XATTR_USER_PREFIX.patch From: https://bugs.gentoo.org/show_bug.cgi?id=470644 Desc: Support for namespace user.pax.* on tmpfs. diff --git a/1224_linux-4.9.225.patch b/1224_linux-4.9.225.patch new file mode 100644 index 00000000..6134f53c --- /dev/null +++ b/1224_linux-4.9.225.patch @@ -0,0 +1,3057 @@ +diff --git a/Documentation/networking/l2tp.txt b/Documentation/networking/l2tp.txt +index 4650a00ed012..9bc271cdc9a8 100644 +--- a/Documentation/networking/l2tp.txt ++++ b/Documentation/networking/l2tp.txt +@@ -177,10 +177,10 @@ setsockopt on the PPPoX socket to set a debug mask. + + The following debug mask bits are available: + +-PPPOL2TP_MSG_DEBUG verbose debug (if compiled in) +-PPPOL2TP_MSG_CONTROL userspace - kernel interface +-PPPOL2TP_MSG_SEQ sequence numbers handling +-PPPOL2TP_MSG_DATA data packets ++L2TP_MSG_DEBUG verbose debug (if compiled in) ++L2TP_MSG_CONTROL userspace - kernel interface ++L2TP_MSG_SEQ sequence numbers handling ++L2TP_MSG_DATA data packets + + If enabled, files under a l2tp debugfs directory can be used to dump + kernel state about L2TP tunnels and sessions. To access it, the +diff --git a/Makefile b/Makefile +index 3e58c142f92f..d17a2ad3cc4d 100644 +--- a/Makefile ++++ b/Makefile +@@ -1,6 +1,6 @@ + VERSION = 4 + PATCHLEVEL = 9 +-SUBLEVEL = 224 ++SUBLEVEL = 225 + EXTRAVERSION = + NAME = Roaring Lionus + +diff --git a/arch/arm/include/asm/futex.h b/arch/arm/include/asm/futex.h +index cc414382dab4..561b2ba6bc28 100644 +--- a/arch/arm/include/asm/futex.h ++++ b/arch/arm/include/asm/futex.h +@@ -162,8 +162,13 @@ arch_futex_atomic_op_inuser(int op, int oparg, int *oval, u32 __user *uaddr) + preempt_enable(); + #endif + +- if (!ret) +- *oval = oldval; ++ /* ++ * Store unconditionally. If ret != 0 the extra store is the least ++ * of the worries but GCC cannot figure out that __futex_atomic_op() ++ * is either setting ret to -EFAULT or storing the old value in ++ * oldval which results in a uninitialized warning at the call site. ++ */ ++ *oval = oldval; + + return ret; + } +diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c +index bc96c8a7fc79..3e4b778f16a5 100644 +--- a/arch/arm64/kernel/machine_kexec.c ++++ b/arch/arm64/kernel/machine_kexec.c +@@ -177,7 +177,8 @@ void machine_kexec(struct kimage *kimage) + /* Flush the reboot_code_buffer in preparation for its execution. */ + __flush_dcache_area(reboot_code_buffer, arm64_relocate_new_kernel_size); + flush_icache_range((uintptr_t)reboot_code_buffer, +- arm64_relocate_new_kernel_size); ++ (uintptr_t)reboot_code_buffer + ++ arm64_relocate_new_kernel_size); + + /* Flush the kimage list and its buffers. */ + kexec_list_flush(kimage); +diff --git a/drivers/base/component.c b/drivers/base/component.c +index 08da6160e94d..55f0856bd9b5 100644 +--- a/drivers/base/component.c ++++ b/drivers/base/component.c +@@ -162,7 +162,8 @@ static int try_to_bring_up_master(struct master *master, + ret = master->ops->bind(master->dev); + if (ret < 0) { + devres_release_group(master->dev, NULL); +- dev_info(master->dev, "master bind failed: %d\n", ret); ++ if (ret != -EPROBE_DEFER) ++ dev_info(master->dev, "master bind failed: %d\n", ret); + return ret; + } + +@@ -431,8 +432,9 @@ static int component_bind(struct component *component, struct master *master, + devres_release_group(component->dev, NULL); + devres_release_group(master->dev, NULL); + +- dev_err(master->dev, "failed to bind %s (ops %ps): %d\n", +- dev_name(component->dev), component->ops, ret); ++ if (ret != -EPROBE_DEFER) ++ dev_err(master->dev, "failed to bind %s (ops %ps): %d\n", ++ dev_name(component->dev), component->ops, ret); + } + + return ret; +diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c +index 2d4aeba579f7..c16c06b3dd2f 100644 +--- a/drivers/dma/tegra210-adma.c ++++ b/drivers/dma/tegra210-adma.c +@@ -793,7 +793,7 @@ static int tegra_adma_probe(struct platform_device *pdev) + ret = dma_async_device_register(&tdma->dma_dev); + if (ret < 0) { + dev_err(&pdev->dev, "ADMA registration failed: %d\n", ret); +- goto irq_dispose; ++ goto rpm_put; + } + + ret = of_dma_controller_register(pdev->dev.of_node, +diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h +index 25c006338100..4630b58634d8 100644 +--- a/drivers/hid/hid-ids.h ++++ b/drivers/hid/hid-ids.h +@@ -353,6 +353,7 @@ + #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7349 0x7349 + #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_73F7 0x73f7 + #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_A001 0xa001 ++#define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_C002 0xc002 + + #define USB_VENDOR_ID_ELAN 0x04f3 + +diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c +index fba655d639af..1207102823de 100644 +--- a/drivers/hid/hid-multitouch.c ++++ b/drivers/hid/hid-multitouch.c +@@ -1332,6 +1332,9 @@ static const struct hid_device_id mt_devices[] = { + { .driver_data = MT_CLS_EGALAX_SERIAL, + MT_USB_DEVICE(USB_VENDOR_ID_DWAV, + USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_A001) }, ++ { .driver_data = MT_CLS_EGALAX, ++ MT_USB_DEVICE(USB_VENDOR_ID_DWAV, ++ USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_C002) }, + + /* Elitegroup panel */ + { .driver_data = MT_CLS_SERIAL, +diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c +index eaa312bc3a3c..c4066276eb7b 100644 +--- a/drivers/i2c/i2c-dev.c ++++ b/drivers/i2c/i2c-dev.c +@@ -47,7 +47,7 @@ + struct i2c_dev { + struct list_head list; + struct i2c_adapter *adap; +- struct device *dev; ++ struct device dev; + struct cdev cdev; + }; + +@@ -91,12 +91,14 @@ static struct i2c_dev *get_free_i2c_dev(struct i2c_adapter *adap) + return i2c_dev; + } + +-static void put_i2c_dev(struct i2c_dev *i2c_dev) ++static void put_i2c_dev(struct i2c_dev *i2c_dev, bool del_cdev) + { + spin_lock(&i2c_dev_list_lock); + list_del(&i2c_dev->list); + spin_unlock(&i2c_dev_list_lock); +- kfree(i2c_dev); ++ if (del_cdev) ++ cdev_device_del(&i2c_dev->cdev, &i2c_dev->dev); ++ put_device(&i2c_dev->dev); + } + + static ssize_t name_show(struct device *dev, +@@ -542,6 +544,14 @@ static const struct file_operations i2cdev_fops = { + + static struct class *i2c_dev_class; + ++static void i2cdev_dev_release(struct device *dev) ++{ ++ struct i2c_dev *i2c_dev; ++ ++ i2c_dev = container_of(dev, struct i2c_dev, dev); ++ kfree(i2c_dev); ++} ++ + static int i2cdev_attach_adapter(struct device *dev, void *dummy) + { + struct i2c_adapter *adap; +@@ -558,27 +568,23 @@ static int i2cdev_attach_adapter(struct device *dev, void *dummy) + + cdev_init(&i2c_dev->cdev, &i2cdev_fops); + i2c_dev->cdev.owner = THIS_MODULE; +- res = cdev_add(&i2c_dev->cdev, MKDEV(I2C_MAJOR, adap->nr), 1); +- if (res) +- goto error_cdev; +- +- /* register this i2c device with the driver core */ +- i2c_dev->dev = device_create(i2c_dev_class, &adap->dev, +- MKDEV(I2C_MAJOR, adap->nr), NULL, +- "i2c-%d", adap->nr); +- if (IS_ERR(i2c_dev->dev)) { +- res = PTR_ERR(i2c_dev->dev); +- goto error; ++ ++ device_initialize(&i2c_dev->dev); ++ i2c_dev->dev.devt = MKDEV(I2C_MAJOR, adap->nr); ++ i2c_dev->dev.class = i2c_dev_class; ++ i2c_dev->dev.parent = &adap->dev; ++ i2c_dev->dev.release = i2cdev_dev_release; ++ dev_set_name(&i2c_dev->dev, "i2c-%d", adap->nr); ++ ++ res = cdev_device_add(&i2c_dev->cdev, &i2c_dev->dev); ++ if (res) { ++ put_i2c_dev(i2c_dev, false); ++ return res; + } + + pr_debug("i2c-dev: adapter [%s] registered as minor %d\n", + adap->name, adap->nr); + return 0; +-error: +- cdev_del(&i2c_dev->cdev); +-error_cdev: +- put_i2c_dev(i2c_dev); +- return res; + } + + static int i2cdev_detach_adapter(struct device *dev, void *dummy) +@@ -594,9 +600,7 @@ static int i2cdev_detach_adapter(struct device *dev, void *dummy) + if (!i2c_dev) /* attach_adapter must have failed */ + return 0; + +- cdev_del(&i2c_dev->cdev); +- put_i2c_dev(i2c_dev); +- device_destroy(i2c_dev_class, MKDEV(I2C_MAJOR, adap->nr)); ++ put_i2c_dev(i2c_dev, true); + + pr_debug("i2c-dev: adapter [%s] unregistered\n", adap->name); + return 0; +diff --git a/drivers/i2c/muxes/i2c-demux-pinctrl.c b/drivers/i2c/muxes/i2c-demux-pinctrl.c +index 3e6fe1760d82..a86c511c29e0 100644 +--- a/drivers/i2c/muxes/i2c-demux-pinctrl.c ++++ b/drivers/i2c/muxes/i2c-demux-pinctrl.c +@@ -270,6 +270,7 @@ static int i2c_demux_pinctrl_probe(struct platform_device *pdev) + err_rollback_available: + device_remove_file(&pdev->dev, &dev_attr_available_masters); + err_rollback: ++ i2c_demux_deactivate_master(priv); + for (j = 0; j < i; j++) { + of_node_put(priv->chan[j].parent_np); + of_changeset_destroy(&priv->chan[j].chgset); +diff --git a/drivers/iio/dac/vf610_dac.c b/drivers/iio/dac/vf610_dac.c +index c4ec7779b394..190a7c1c5604 100644 +--- a/drivers/iio/dac/vf610_dac.c ++++ b/drivers/iio/dac/vf610_dac.c +@@ -235,6 +235,7 @@ static int vf610_dac_probe(struct platform_device *pdev) + return 0; + + error_iio_device_register: ++ vf610_dac_exit(info); + clk_disable_unprepare(info->clk); + + return ret; +diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c +index e6ae8d123984..a3279f303b49 100644 +--- a/drivers/iommu/amd_iommu_init.c ++++ b/drivers/iommu/amd_iommu_init.c +@@ -1171,8 +1171,8 @@ static int __init init_iommu_from_acpi(struct amd_iommu *iommu, + } + case IVHD_DEV_ACPI_HID: { + u16 devid; +- u8 hid[ACPIHID_HID_LEN] = {0}; +- u8 uid[ACPIHID_UID_LEN] = {0}; ++ u8 hid[ACPIHID_HID_LEN]; ++ u8 uid[ACPIHID_UID_LEN]; + int ret; + + if (h->type != 0x40) { +@@ -1189,6 +1189,7 @@ static int __init init_iommu_from_acpi(struct amd_iommu *iommu, + break; + } + ++ uid[0] = '\0'; + switch (e->uidf) { + case UID_NOT_PRESENT: + +@@ -1203,8 +1204,8 @@ static int __init init_iommu_from_acpi(struct amd_iommu *iommu, + break; + case UID_IS_CHARACTER: + +- memcpy(uid, (u8 *)(&e->uid), ACPIHID_UID_LEN - 1); +- uid[ACPIHID_UID_LEN - 1] = '\0'; ++ memcpy(uid, &e->uid, e->uidl); ++ uid[e->uidl] = '\0'; + + break; + default: +diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c +index 451d417eb451..1c8df33404b0 100644 +--- a/drivers/misc/mei/client.c ++++ b/drivers/misc/mei/client.c +@@ -276,6 +276,7 @@ void mei_me_cl_rm_by_uuid(struct mei_device *dev, const uuid_le *uuid) + down_write(&dev->me_clients_rwsem); + me_cl = __mei_me_cl_by_uuid(dev, uuid); + __mei_me_cl_del(dev, me_cl); ++ mei_me_cl_put(me_cl); + up_write(&dev->me_clients_rwsem); + } + +@@ -297,6 +298,7 @@ void mei_me_cl_rm_by_uuid_id(struct mei_device *dev, const uuid_le *uuid, u8 id) + down_write(&dev->me_clients_rwsem); + me_cl = __mei_me_cl_by_uuid_id(dev, uuid, id); + __mei_me_cl_del(dev, me_cl); ++ mei_me_cl_put(me_cl); + up_write(&dev->me_clients_rwsem); + } + +diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +index 5478a2ab45c4..54b5f61c8ed9 100644 +--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c ++++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +@@ -2236,8 +2236,6 @@ static int cxgb_up(struct adapter *adap) + #if IS_ENABLED(CONFIG_IPV6) + update_clip(adap); + #endif +- /* Initialize hash mac addr list*/ +- INIT_LIST_HEAD(&adap->mac_hlist); + return err; + + irq_err: +@@ -2259,6 +2257,7 @@ static void cxgb_down(struct adapter *adapter) + + t4_sge_stop(adapter); + t4_free_sge_resources(adapter); ++ + adapter->flags &= ~FULL_INIT_DONE; + } + +@@ -4789,6 +4788,9 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) + (is_t5(adapter->params.chip) ? STATMODE_V(0) : + T6_STATMODE_V(0))); + ++ /* Initialize hash mac addr list */ ++ INIT_LIST_HEAD(&adapter->mac_hlist); ++ + for_each_port(adapter, i) { + netdev = alloc_etherdev_mq(sizeof(struct port_info), + MAX_ETH_QSETS); +@@ -5067,6 +5069,7 @@ sriov: + static void remove_one(struct pci_dev *pdev) + { + struct adapter *adapter = pci_get_drvdata(pdev); ++ struct hash_mac_addr *entry, *tmp; + + if (!adapter) { + pci_release_regions(pdev); +@@ -5105,6 +5108,12 @@ static void remove_one(struct pci_dev *pdev) + if (adapter->num_uld || adapter->num_ofld_uld) + t4_uld_mem_free(adapter); + free_some_resources(adapter); ++ list_for_each_entry_safe(entry, tmp, &adapter->mac_hlist, ++ list) { ++ list_del(&entry->list); ++ kfree(entry); ++ } ++ + #if IS_ENABLED(CONFIG_IPV6) + t4_cleanup_clip_tbl(adapter); + #endif +diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c +index 9eb3071b69a4..17db5be9d2b7 100644 +--- a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c ++++ b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c +@@ -719,9 +719,6 @@ static int adapter_up(struct adapter *adapter) + if (adapter->flags & USING_MSIX) + name_msix_vecs(adapter); + +- /* Initialize hash mac addr list*/ +- INIT_LIST_HEAD(&adapter->mac_hlist); +- + adapter->flags |= FULL_INIT_DONE; + } + +@@ -2902,6 +2899,9 @@ static int cxgb4vf_pci_probe(struct pci_dev *pdev, + if (err) + goto err_unmap_bar; + ++ /* Initialize hash mac addr list */ ++ INIT_LIST_HEAD(&adapter->mac_hlist); ++ + /* + * Allocate our "adapter ports" and stitch everything together. + */ +diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c +index 7e35bd665630..90eab0521be1 100644 +--- a/drivers/net/ethernet/intel/igb/igb_main.c ++++ b/drivers/net/ethernet/intel/igb/igb_main.c +@@ -3395,7 +3395,7 @@ void igb_configure_tx_ring(struct igb_adapter *adapter, + tdba & 0x00000000ffffffffULL); + wr32(E1000_TDBAH(reg_idx), tdba >> 32); + +- ring->tail = hw->hw_addr + E1000_TDT(reg_idx); ++ ring->tail = adapter->io_addr + E1000_TDT(reg_idx); + wr32(E1000_TDH(reg_idx), 0); + writel(0, ring->tail); + +@@ -3734,7 +3734,7 @@ void igb_configure_rx_ring(struct igb_adapter *adapter, + ring->count * sizeof(union e1000_adv_rx_desc)); + + /* initialize head and tail */ +- ring->tail = hw->hw_addr + E1000_RDT(reg_idx); ++ ring->tail = adapter->io_addr + E1000_RDT(reg_idx); + wr32(E1000_RDH(reg_idx), 0); + writel(0, ring->tail); + +diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c +index a9e8a7356c41..fe844888e0ed 100644 +--- a/drivers/net/gtp.c ++++ b/drivers/net/gtp.c +@@ -1108,11 +1108,11 @@ static struct genl_family gtp_genl_family = { + }; + + static int gtp_genl_fill_info(struct sk_buff *skb, u32 snd_portid, u32 snd_seq, +- u32 type, struct pdp_ctx *pctx) ++ int flags, u32 type, struct pdp_ctx *pctx) + { + void *genlh; + +- genlh = genlmsg_put(skb, snd_portid, snd_seq, >p_genl_family, 0, ++ genlh = genlmsg_put(skb, snd_portid, snd_seq, >p_genl_family, flags, + type); + if (genlh == NULL) + goto nlmsg_failure; +@@ -1208,8 +1208,8 @@ static int gtp_genl_get_pdp(struct sk_buff *skb, struct genl_info *info) + goto err_unlock; + } + +- err = gtp_genl_fill_info(skb2, NETLINK_CB(skb).portid, +- info->snd_seq, info->nlhdr->nlmsg_type, pctx); ++ err = gtp_genl_fill_info(skb2, NETLINK_CB(skb).portid, info->snd_seq, ++ 0, info->nlhdr->nlmsg_type, pctx); + if (err < 0) + goto err_unlock_free; + +@@ -1252,6 +1252,7 @@ static int gtp_genl_dump_pdp(struct sk_buff *skb, + gtp_genl_fill_info(skb, + NETLINK_CB(cb->skb).portid, + cb->nlh->nlmsg_seq, ++ NLM_F_MULTI, + cb->nlh->nlmsg_type, pctx)) { + cb->args[0] = i; + cb->args[1] = j; +diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c +index 0c46ada027cf..e90ecb179622 100644 +--- a/drivers/nvdimm/btt.c ++++ b/drivers/nvdimm/btt.c +@@ -447,9 +447,9 @@ static int btt_log_init(struct arena_info *arena) + + static int btt_freelist_init(struct arena_info *arena) + { +- int old, new, ret; ++ int new, ret; + u32 i, map_entry; +- struct log_entry log_new, log_old; ++ struct log_entry log_new; + + arena->freelist = kcalloc(arena->nfree, sizeof(struct free_entry), + GFP_KERNEL); +@@ -457,10 +457,6 @@ static int btt_freelist_init(struct arena_info *arena) + return -ENOMEM; + + for (i = 0; i < arena->nfree; i++) { +- old = btt_log_read(arena, i, &log_old, LOG_OLD_ENT); +- if (old < 0) +- return old; +- + new = btt_log_read(arena, i, &log_new, LOG_NEW_ENT); + if (new < 0) + return new; +diff --git a/drivers/platform/x86/alienware-wmi.c b/drivers/platform/x86/alienware-wmi.c +index bee2115ecf10..ec7482c7e7eb 100644 +--- a/drivers/platform/x86/alienware-wmi.c ++++ b/drivers/platform/x86/alienware-wmi.c +@@ -504,23 +504,22 @@ static acpi_status alienware_wmax_command(struct wmax_basic_args *in_args, + + input.length = (acpi_size) sizeof(*in_args); + input.pointer = in_args; +- if (out_data != NULL) { ++ if (out_data) { + output.length = ACPI_ALLOCATE_BUFFER; + output.pointer = NULL; + status = wmi_evaluate_method(WMAX_CONTROL_GUID, 1, + command, &input, &output); +- } else ++ if (ACPI_SUCCESS(status)) { ++ obj = (union acpi_object *)output.pointer; ++ if (obj && obj->type == ACPI_TYPE_INTEGER) ++ *out_data = (u32)obj->integer.value; ++ } ++ kfree(output.pointer); ++ } else { + status = wmi_evaluate_method(WMAX_CONTROL_GUID, 1, + command, &input, NULL); +- +- if (ACPI_SUCCESS(status) && out_data != NULL) { +- obj = (union acpi_object *)output.pointer; +- if (obj && obj->type == ACPI_TYPE_INTEGER) +- *out_data = (u32) obj->integer.value; + } +- kfree(output.pointer); + return status; +- + } + + /* +diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c +index 0fd7e40b86a0..8137aa343706 100644 +--- a/drivers/platform/x86/asus-nb-wmi.c ++++ b/drivers/platform/x86/asus-nb-wmi.c +@@ -561,9 +561,33 @@ static struct asus_wmi_driver asus_nb_wmi_driver = { + .detect_quirks = asus_nb_wmi_quirks, + }; + ++static const struct dmi_system_id asus_nb_wmi_blacklist[] __initconst = { ++ { ++ /* ++ * asus-nb-wm adds no functionality. The T100TA has a detachable ++ * USB kbd, so no hotkeys and it has no WMI rfkill; and loading ++ * asus-nb-wm causes the camera LED to turn and _stay_ on. ++ */ ++ .matches = { ++ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), ++ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100TA"), ++ }, ++ }, ++ { ++ /* The Asus T200TA has the same issue as the T100TA */ ++ .matches = { ++ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), ++ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T200TA"), ++ }, ++ }, ++ {} /* Terminating entry */ ++}; + + static int __init asus_nb_wmi_init(void) + { ++ if (dmi_check_system(asus_nb_wmi_blacklist)) ++ return -ENODEV; ++ + return asus_wmi_register_driver(&asus_nb_wmi_driver); + } + +diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c +index 28c45db45aba..ebe8e8dc4677 100644 +--- a/drivers/rapidio/devices/rio_mport_cdev.c ++++ b/drivers/rapidio/devices/rio_mport_cdev.c +@@ -905,6 +905,11 @@ rio_dma_transfer(struct file *filp, u32 transfer_mode, + rmcd_error("pinned %ld out of %ld pages", + pinned, nr_pages); + ret = -EFAULT; ++ /* ++ * Set nr_pages up to mean "how many pages to unpin, in ++ * the error handler: ++ */ ++ nr_pages = pinned; + goto err_pg; + } + +diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c +index 2633d2bfb1b4..9ef9cbfd8926 100644 +--- a/drivers/staging/greybus/uart.c ++++ b/drivers/staging/greybus/uart.c +@@ -539,9 +539,9 @@ static void gb_tty_set_termios(struct tty_struct *tty, + } + + if (C_CRTSCTS(tty) && C_BAUD(tty) != B0) +- newline.flow_control |= GB_SERIAL_AUTO_RTSCTS_EN; ++ newline.flow_control = GB_SERIAL_AUTO_RTSCTS_EN; + else +- newline.flow_control &= ~GB_SERIAL_AUTO_RTSCTS_EN; ++ newline.flow_control = 0; + + if (memcmp(&gb_tty->line_coding, &newline, sizeof(newline))) { + memcpy(&gb_tty->line_coding, &newline, sizeof(newline)); +diff --git a/drivers/staging/iio/accel/sca3000_ring.c b/drivers/staging/iio/accel/sca3000_ring.c +index d1cb9b9cf22b..391cbcc4ed77 100644 +--- a/drivers/staging/iio/accel/sca3000_ring.c ++++ b/drivers/staging/iio/accel/sca3000_ring.c +@@ -56,7 +56,7 @@ static int sca3000_read_data(struct sca3000_state *st, + st->tx[0] = SCA3000_READ_REG(reg_address_high); + ret = spi_sync_transfer(st->us, xfer, ARRAY_SIZE(xfer)); + if (ret) { +- dev_err(get_device(&st->us->dev), "problem reading register"); ++ dev_err(&st->us->dev, "problem reading register"); + goto error_free_rx; + } + +diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c +index 598f0faa48c8..0f5eb2bf5f73 100644 +--- a/drivers/staging/iio/resolver/ad2s1210.c ++++ b/drivers/staging/iio/resolver/ad2s1210.c +@@ -126,17 +126,24 @@ static int ad2s1210_config_write(struct ad2s1210_state *st, u8 data) + static int ad2s1210_config_read(struct ad2s1210_state *st, + unsigned char address) + { +- struct spi_transfer xfer = { +- .len = 2, +- .rx_buf = st->rx, +- .tx_buf = st->tx, ++ struct spi_transfer xfers[] = { ++ { ++ .len = 1, ++ .rx_buf = &st->rx[0], ++ .tx_buf = &st->tx[0], ++ .cs_change = 1, ++ }, { ++ .len = 1, ++ .rx_buf = &st->rx[1], ++ .tx_buf = &st->tx[1], ++ }, + }; + int ret = 0; + + ad2s1210_set_mode(MOD_CONFIG, st); + st->tx[0] = address | AD2S1210_MSB_IS_HIGH; + st->tx[1] = AD2S1210_REG_FAULT; +- ret = spi_sync_transfer(st->sdev, &xfer, 1); ++ ret = spi_sync_transfer(st->sdev, xfers, 2); + if (ret < 0) + return ret; + st->old_data = true; +diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c +index 2e541a029657..e33d23c2f6ea 100644 +--- a/drivers/usb/core/message.c ++++ b/drivers/usb/core/message.c +@@ -1081,11 +1081,11 @@ void usb_disable_endpoint(struct usb_device *dev, unsigned int epaddr, + + if (usb_endpoint_out(epaddr)) { + ep = dev->ep_out[epnum]; +- if (reset_hardware) ++ if (reset_hardware && epnum != 0) + dev->ep_out[epnum] = NULL; + } else { + ep = dev->ep_in[epnum]; +- if (reset_hardware) ++ if (reset_hardware && epnum != 0) + dev->ep_in[epnum] = NULL; + } + if (ep) { +diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c +index 9e17d933ea94..3167f276c4c2 100644 +--- a/drivers/watchdog/watchdog_dev.c ++++ b/drivers/watchdog/watchdog_dev.c +@@ -38,7 +38,6 @@ + #include <linux/init.h> /* For __init/__exit/... */ + #include <linux/jiffies.h> /* For timeout functions */ + #include <linux/kernel.h> /* For printk/panic/... */ +-#include <linux/kref.h> /* For data references */ + #include <linux/miscdevice.h> /* For handling misc devices */ + #include <linux/module.h> /* For module stuff/... */ + #include <linux/mutex.h> /* For mutexes */ +@@ -53,14 +52,14 @@ + + /* + * struct watchdog_core_data - watchdog core internal data +- * @kref: Reference count. ++ * @dev: The watchdog's internal device + * @cdev: The watchdog's Character device. + * @wdd: Pointer to watchdog device. + * @lock: Lock for watchdog core. + * @status: Watchdog core internal status bits. + */ + struct watchdog_core_data { +- struct kref kref; ++ struct device dev; + struct cdev cdev; + struct watchdog_device *wdd; + struct mutex lock; +@@ -794,7 +793,7 @@ static int watchdog_open(struct inode *inode, struct file *file) + file->private_data = wd_data; + + if (!hw_running) +- kref_get(&wd_data->kref); ++ get_device(&wd_data->dev); + + /* dev/watchdog is a virtual (and thus non-seekable) filesystem */ + return nonseekable_open(inode, file); +@@ -806,11 +805,11 @@ out_clear: + return err; + } + +-static void watchdog_core_data_release(struct kref *kref) ++static void watchdog_core_data_release(struct device *dev) + { + struct watchdog_core_data *wd_data; + +- wd_data = container_of(kref, struct watchdog_core_data, kref); ++ wd_data = container_of(dev, struct watchdog_core_data, dev); + + kfree(wd_data); + } +@@ -870,7 +869,7 @@ done: + */ + if (!running) { + module_put(wd_data->cdev.owner); +- kref_put(&wd_data->kref, watchdog_core_data_release); ++ put_device(&wd_data->dev); + } + return 0; + } +@@ -889,17 +888,22 @@ static struct miscdevice watchdog_miscdev = { + .fops = &watchdog_fops, + }; + ++static struct class watchdog_class = { ++ .name = "watchdog", ++ .owner = THIS_MODULE, ++ .dev_groups = wdt_groups, ++}; ++ + /* + * watchdog_cdev_register: register watchdog character device + * @wdd: watchdog device +- * @devno: character device number + * + * Register a watchdog character device including handling the legacy + * /dev/watchdog node. /dev/watchdog is actually a miscdevice and + * thus we set it up like that. + */ + +-static int watchdog_cdev_register(struct watchdog_device *wdd, dev_t devno) ++static int watchdog_cdev_register(struct watchdog_device *wdd) + { + struct watchdog_core_data *wd_data; + int err; +@@ -907,7 +911,6 @@ static int watchdog_cdev_register(struct watchdog_device *wdd, dev_t devno) + wd_data = kzalloc(sizeof(struct watchdog_core_data), GFP_KERNEL); + if (!wd_data) + return -ENOMEM; +- kref_init(&wd_data->kref); + mutex_init(&wd_data->lock); + + wd_data->wdd = wdd; +@@ -934,23 +937,33 @@ static int watchdog_cdev_register(struct watchdog_device *wdd, dev_t devno) + } + } + ++ device_initialize(&wd_data->dev); ++ wd_data->dev.devt = MKDEV(MAJOR(watchdog_devt), wdd->id); ++ wd_data->dev.class = &watchdog_class; ++ wd_data->dev.parent = wdd->parent; ++ wd_data->dev.groups = wdd->groups; ++ wd_data->dev.release = watchdog_core_data_release; ++ dev_set_drvdata(&wd_data->dev, wdd); ++ dev_set_name(&wd_data->dev, "watchdog%d", wdd->id); ++ + /* Fill in the data structures */ + cdev_init(&wd_data->cdev, &watchdog_fops); +- wd_data->cdev.owner = wdd->ops->owner; + + /* Add the device */ +- err = cdev_add(&wd_data->cdev, devno, 1); ++ err = cdev_device_add(&wd_data->cdev, &wd_data->dev); + if (err) { + pr_err("watchdog%d unable to add device %d:%d\n", + wdd->id, MAJOR(watchdog_devt), wdd->id); + if (wdd->id == 0) { + misc_deregister(&watchdog_miscdev); + old_wd_data = NULL; +- kref_put(&wd_data->kref, watchdog_core_data_release); ++ put_device(&wd_data->dev); + } + return err; + } + ++ wd_data->cdev.owner = wdd->ops->owner; ++ + /* Record time of most recent heartbeat as 'just before now'. */ + wd_data->last_hw_keepalive = jiffies - 1; + +@@ -960,7 +973,7 @@ static int watchdog_cdev_register(struct watchdog_device *wdd, dev_t devno) + */ + if (watchdog_hw_running(wdd)) { + __module_get(wdd->ops->owner); +- kref_get(&wd_data->kref); ++ get_device(&wd_data->dev); + queue_delayed_work(watchdog_wq, &wd_data->work, 0); + } + +@@ -979,7 +992,7 @@ static void watchdog_cdev_unregister(struct watchdog_device *wdd) + { + struct watchdog_core_data *wd_data = wdd->wd_data; + +- cdev_del(&wd_data->cdev); ++ cdev_device_del(&wd_data->cdev, &wd_data->dev); + if (wdd->id == 0) { + misc_deregister(&watchdog_miscdev); + old_wd_data = NULL; +@@ -992,15 +1005,9 @@ static void watchdog_cdev_unregister(struct watchdog_device *wdd) + + cancel_delayed_work_sync(&wd_data->work); + +- kref_put(&wd_data->kref, watchdog_core_data_release); ++ put_device(&wd_data->dev); + } + +-static struct class watchdog_class = { +- .name = "watchdog", +- .owner = THIS_MODULE, +- .dev_groups = wdt_groups, +-}; +- + /* + * watchdog_dev_register: register a watchdog device + * @wdd: watchdog device +@@ -1012,27 +1019,14 @@ static struct class watchdog_class = { + + int watchdog_dev_register(struct watchdog_device *wdd) + { +- struct device *dev; +- dev_t devno; + int ret; + +- devno = MKDEV(MAJOR(watchdog_devt), wdd->id); +- +- ret = watchdog_cdev_register(wdd, devno); ++ ret = watchdog_cdev_register(wdd); + if (ret) + return ret; + +- dev = device_create_with_groups(&watchdog_class, wdd->parent, +- devno, wdd, wdd->groups, +- "watchdog%d", wdd->id); +- if (IS_ERR(dev)) { +- watchdog_cdev_unregister(wdd); +- return PTR_ERR(dev); +- } +- + ret = watchdog_register_pretimeout(wdd); + if (ret) { +- device_destroy(&watchdog_class, devno); + watchdog_cdev_unregister(wdd); + } + +@@ -1050,7 +1044,6 @@ int watchdog_dev_register(struct watchdog_device *wdd) + void watchdog_dev_unregister(struct watchdog_device *wdd) + { + watchdog_unregister_pretimeout(wdd); +- device_destroy(&watchdog_class, wdd->wd_data->cdev.dev); + watchdog_cdev_unregister(wdd); + } + +diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c +index 617e9ae67f50..e11aacb35d6b 100644 +--- a/fs/ceph/caps.c ++++ b/fs/ceph/caps.c +@@ -3394,6 +3394,7 @@ retry: + WARN_ON(1); + tsession = NULL; + target = -1; ++ mutex_lock(&session->s_mutex); + } + goto retry; + +diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c +index c2ef617d2f97..c875f246cb0e 100644 +--- a/fs/configfs/dir.c ++++ b/fs/configfs/dir.c +@@ -1537,6 +1537,7 @@ static int configfs_rmdir(struct inode *dir, struct dentry *dentry) + spin_lock(&configfs_dirent_lock); + configfs_detach_rollback(dentry); + spin_unlock(&configfs_dirent_lock); ++ config_item_put(parent_item); + return -EINTR; + } + frag->frag_dead = true; +diff --git a/fs/file.c b/fs/file.c +index 09aac4d4729b..82d3f925bab3 100644 +--- a/fs/file.c ++++ b/fs/file.c +@@ -89,7 +89,7 @@ static void copy_fd_bitmaps(struct fdtable *nfdt, struct fdtable *ofdt, + */ + static void copy_fdtable(struct fdtable *nfdt, struct fdtable *ofdt) + { +- unsigned int cpy, set; ++ size_t cpy, set; + + BUG_ON(nfdt->max_fds < ofdt->max_fds); + +diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c +index adc1a97cfe96..efd44d5645d8 100644 +--- a/fs/gfs2/glock.c ++++ b/fs/gfs2/glock.c +@@ -548,9 +548,6 @@ __acquires(&gl->gl_lockref.lock) + goto out_unlock; + if (nonblock) + goto out_sched; +- smp_mb(); +- if (atomic_read(&gl->gl_revokes) != 0) +- goto out_sched; + set_bit(GLF_DEMOTE_IN_PROGRESS, &gl->gl_flags); + GLOCK_BUG_ON(gl, gl->gl_demote_state == LM_ST_EXCLUSIVE); + gl->gl_target = gl->gl_demote_state; +diff --git a/include/linux/net.h b/include/linux/net.h +index cd0c8bd0a1de..54270c4707cf 100644 +--- a/include/linux/net.h ++++ b/include/linux/net.h +@@ -298,6 +298,9 @@ int kernel_sendpage(struct socket *sock, struct page *page, int offset, + int kernel_sock_ioctl(struct socket *sock, int cmd, unsigned long arg); + int kernel_sock_shutdown(struct socket *sock, enum sock_shutdown_cmd how); + ++/* Routine returns the IP overhead imposed by a (caller-protected) socket. */ ++u32 kernel_sock_ip_overhead(struct sock *sk); ++ + #define MODULE_ALIAS_NETPROTO(proto) \ + MODULE_ALIAS("net-pf-" __stringify(proto)) + +diff --git a/include/linux/padata.h b/include/linux/padata.h +index 0f9e567d5e15..3afa17ed59da 100644 +--- a/include/linux/padata.h ++++ b/include/linux/padata.h +@@ -24,7 +24,6 @@ + #include <linux/workqueue.h> + #include <linux/spinlock.h> + #include <linux/list.h> +-#include <linux/timer.h> + #include <linux/notifier.h> + #include <linux/kobject.h> + +@@ -37,6 +36,7 @@ + * @list: List entry, to attach to the padata lists. + * @pd: Pointer to the internal control structure. + * @cb_cpu: Callback cpu for serializatioon. ++ * @cpu: Cpu for parallelization. + * @seq_nr: Sequence number of the parallelized data object. + * @info: Used to pass information from the parallel to the serial function. + * @parallel: Parallel execution function. +@@ -46,6 +46,7 @@ struct padata_priv { + struct list_head list; + struct parallel_data *pd; + int cb_cpu; ++ int cpu; + int info; + void (*parallel)(struct padata_priv *padata); + void (*serial)(struct padata_priv *padata); +@@ -83,7 +84,6 @@ struct padata_serial_queue { + * @serial: List to wait for serialization after reordering. + * @pwork: work struct for parallelization. + * @swork: work struct for serialization. +- * @pd: Backpointer to the internal control structure. + * @work: work struct for parallelization. + * @num_obj: Number of objects that are processed by this cpu. + * @cpu_index: Index of the cpu. +@@ -91,7 +91,6 @@ struct padata_serial_queue { + struct padata_parallel_queue { + struct padata_list parallel; + struct padata_list reorder; +- struct parallel_data *pd; + struct work_struct work; + atomic_t num_obj; + int cpu_index; +@@ -118,10 +117,10 @@ struct padata_cpumask { + * @reorder_objects: Number of objects waiting in the reorder queues. + * @refcnt: Number of objects holding a reference on this parallel_data. + * @max_seq_nr: Maximal used sequence number. ++ * @cpu: Next CPU to be processed. + * @cpumask: The cpumasks in use for parallel and serial workers. ++ * @reorder_work: work struct for reordering. + * @lock: Reorder lock. +- * @processed: Number of already processed objects. +- * @timer: Reorder timer. + */ + struct parallel_data { + struct padata_instance *pinst; +@@ -130,10 +129,10 @@ struct parallel_data { + atomic_t reorder_objects; + atomic_t refcnt; + atomic_t seq_nr; ++ int cpu; + struct padata_cpumask cpumask; ++ struct work_struct reorder_work; + spinlock_t lock ____cacheline_aligned; +- unsigned int processed; +- struct timer_list timer; + }; + + /** +diff --git a/include/uapi/linux/if_pppol2tp.h b/include/uapi/linux/if_pppol2tp.h +index 4bd1f55d6377..6418c4d10241 100644 +--- a/include/uapi/linux/if_pppol2tp.h ++++ b/include/uapi/linux/if_pppol2tp.h +@@ -18,6 +18,7 @@ + #include <linux/types.h> + #include <linux/in.h> + #include <linux/in6.h> ++#include <linux/l2tp.h> + + /* Structure used to connect() the socket to a particular tunnel UDP + * socket over IPv4. +@@ -90,14 +91,12 @@ enum { + PPPOL2TP_SO_REORDERTO = 5, + }; + +-/* Debug message categories for the DEBUG socket option */ ++/* Debug message categories for the DEBUG socket option (deprecated) */ + enum { +- PPPOL2TP_MSG_DEBUG = (1 << 0), /* verbose debug (if +- * compiled in) */ +- PPPOL2TP_MSG_CONTROL = (1 << 1), /* userspace - kernel +- * interface */ +- PPPOL2TP_MSG_SEQ = (1 << 2), /* sequence numbers */ +- PPPOL2TP_MSG_DATA = (1 << 3), /* data packets */ ++ PPPOL2TP_MSG_DEBUG = L2TP_MSG_DEBUG, ++ PPPOL2TP_MSG_CONTROL = L2TP_MSG_CONTROL, ++ PPPOL2TP_MSG_SEQ = L2TP_MSG_SEQ, ++ PPPOL2TP_MSG_DATA = L2TP_MSG_DATA, + }; + + +diff --git a/include/uapi/linux/l2tp.h b/include/uapi/linux/l2tp.h +index 4bd27d0270a2..bb2d62037037 100644 +--- a/include/uapi/linux/l2tp.h ++++ b/include/uapi/linux/l2tp.h +@@ -108,7 +108,7 @@ enum { + L2TP_ATTR_VLAN_ID, /* u16 */ + L2TP_ATTR_COOKIE, /* 0, 4 or 8 bytes */ + L2TP_ATTR_PEER_COOKIE, /* 0, 4 or 8 bytes */ +- L2TP_ATTR_DEBUG, /* u32 */ ++ L2TP_ATTR_DEBUG, /* u32, enum l2tp_debug_flags */ + L2TP_ATTR_RECV_SEQ, /* u8 */ + L2TP_ATTR_SEND_SEQ, /* u8 */ + L2TP_ATTR_LNS_MODE, /* u8 */ +@@ -175,6 +175,21 @@ enum l2tp_seqmode { + L2TP_SEQ_ALL = 2, + }; + ++/** ++ * enum l2tp_debug_flags - debug message categories for L2TP tunnels/sessions ++ * ++ * @L2TP_MSG_DEBUG: verbose debug (if compiled in) ++ * @L2TP_MSG_CONTROL: userspace - kernel interface ++ * @L2TP_MSG_SEQ: sequence numbers ++ * @L2TP_MSG_DATA: data packets ++ */ ++enum l2tp_debug_flags { ++ L2TP_MSG_DEBUG = (1 << 0), ++ L2TP_MSG_CONTROL = (1 << 1), ++ L2TP_MSG_SEQ = (1 << 2), ++ L2TP_MSG_DATA = (1 << 3), ++}; ++ + /* + * NETLINK_GENERIC related info + */ +diff --git a/kernel/padata.c b/kernel/padata.c +index 6939111b3cbe..e82f066d63ac 100644 +--- a/kernel/padata.c ++++ b/kernel/padata.c +@@ -66,15 +66,11 @@ static int padata_cpu_hash(struct parallel_data *pd) + static void padata_parallel_worker(struct work_struct *parallel_work) + { + struct padata_parallel_queue *pqueue; +- struct parallel_data *pd; +- struct padata_instance *pinst; + LIST_HEAD(local_list); + + local_bh_disable(); + pqueue = container_of(parallel_work, + struct padata_parallel_queue, work); +- pd = pqueue->pd; +- pinst = pd->pinst; + + spin_lock(&pqueue->parallel.lock); + list_replace_init(&pqueue->parallel.list, &local_list); +@@ -137,6 +133,7 @@ int padata_do_parallel(struct padata_instance *pinst, + padata->cb_cpu = cb_cpu; + + target_cpu = padata_cpu_hash(pd); ++ padata->cpu = target_cpu; + queue = per_cpu_ptr(pd->pqueue, target_cpu); + + spin_lock(&queue->parallel.lock); +@@ -160,8 +157,6 @@ EXPORT_SYMBOL(padata_do_parallel); + * A pointer to the control struct of the next object that needs + * serialization, if present in one of the percpu reorder queues. + * +- * NULL, if all percpu reorder queues are empty. +- * + * -EINPROGRESS, if the next object that needs serialization will + * be parallel processed by another cpu and is not yet present in + * the cpu's reorder queue. +@@ -171,25 +166,12 @@ EXPORT_SYMBOL(padata_do_parallel); + */ + static struct padata_priv *padata_get_next(struct parallel_data *pd) + { +- int cpu, num_cpus; +- unsigned int next_nr, next_index; + struct padata_parallel_queue *next_queue; + struct padata_priv *padata; + struct padata_list *reorder; ++ int cpu = pd->cpu; + +- num_cpus = cpumask_weight(pd->cpumask.pcpu); +- +- /* +- * Calculate the percpu reorder queue and the sequence +- * number of the next object. +- */ +- next_nr = pd->processed; +- next_index = next_nr % num_cpus; +- cpu = padata_index_to_cpu(pd, next_index); + next_queue = per_cpu_ptr(pd->pqueue, cpu); +- +- padata = NULL; +- + reorder = &next_queue->reorder; + + spin_lock(&reorder->lock); +@@ -200,7 +182,8 @@ static struct padata_priv *padata_get_next(struct parallel_data *pd) + list_del_init(&padata->list); + atomic_dec(&pd->reorder_objects); + +- pd->processed++; ++ pd->cpu = cpumask_next_wrap(cpu, pd->cpumask.pcpu, -1, ++ false); + + spin_unlock(&reorder->lock); + goto out; +@@ -223,6 +206,7 @@ static void padata_reorder(struct parallel_data *pd) + struct padata_priv *padata; + struct padata_serial_queue *squeue; + struct padata_instance *pinst = pd->pinst; ++ struct padata_parallel_queue *next_queue; + + /* + * We need to ensure that only one cpu can work on dequeueing of +@@ -241,12 +225,11 @@ static void padata_reorder(struct parallel_data *pd) + padata = padata_get_next(pd); + + /* +- * All reorder queues are empty, or the next object that needs +- * serialization is parallel processed by another cpu and is +- * still on it's way to the cpu's reorder queue, nothing to +- * do for now. ++ * If the next object that needs serialization is parallel ++ * processed by another cpu and is still on it's way to the ++ * cpu's reorder queue, nothing to do for now. + */ +- if (!padata || PTR_ERR(padata) == -EINPROGRESS) ++ if (PTR_ERR(padata) == -EINPROGRESS) + break; + + /* +@@ -255,7 +238,6 @@ static void padata_reorder(struct parallel_data *pd) + * so exit immediately. + */ + if (PTR_ERR(padata) == -ENODATA) { +- del_timer(&pd->timer); + spin_unlock_bh(&pd->lock); + return; + } +@@ -274,28 +256,27 @@ static void padata_reorder(struct parallel_data *pd) + + /* + * The next object that needs serialization might have arrived to +- * the reorder queues in the meantime, we will be called again +- * from the timer function if no one else cares for it. ++ * the reorder queues in the meantime. + * +- * Ensure reorder_objects is read after pd->lock is dropped so we see +- * an increment from another task in padata_do_serial. Pairs with ++ * Ensure reorder queue is read after pd->lock is dropped so we see ++ * new objects from another task in padata_do_serial. Pairs with + * smp_mb__after_atomic in padata_do_serial. + */ + smp_mb(); +- if (atomic_read(&pd->reorder_objects) +- && !(pinst->flags & PADATA_RESET)) +- mod_timer(&pd->timer, jiffies + HZ); +- else +- del_timer(&pd->timer); + +- return; ++ next_queue = per_cpu_ptr(pd->pqueue, pd->cpu); ++ if (!list_empty(&next_queue->reorder.list)) ++ queue_work(pinst->wq, &pd->reorder_work); + } + +-static void padata_reorder_timer(unsigned long arg) ++static void invoke_padata_reorder(struct work_struct *work) + { +- struct parallel_data *pd = (struct parallel_data *)arg; ++ struct parallel_data *pd; + ++ local_bh_disable(); ++ pd = container_of(work, struct parallel_data, reorder_work); + padata_reorder(pd); ++ local_bh_enable(); + } + + static void padata_serial_worker(struct work_struct *serial_work) +@@ -342,29 +323,22 @@ static void padata_serial_worker(struct work_struct *serial_work) + */ + void padata_do_serial(struct padata_priv *padata) + { +- int cpu; +- struct padata_parallel_queue *pqueue; +- struct parallel_data *pd; +- +- pd = padata->pd; +- +- cpu = get_cpu(); +- pqueue = per_cpu_ptr(pd->pqueue, cpu); ++ struct parallel_data *pd = padata->pd; ++ struct padata_parallel_queue *pqueue = per_cpu_ptr(pd->pqueue, ++ padata->cpu); + + spin_lock(&pqueue->reorder.lock); +- atomic_inc(&pd->reorder_objects); + list_add_tail(&padata->list, &pqueue->reorder.list); ++ atomic_inc(&pd->reorder_objects); + spin_unlock(&pqueue->reorder.lock); + + /* +- * Ensure the atomic_inc of reorder_objects above is ordered correctly ++ * Ensure the addition to the reorder list is ordered correctly + * with the trylock of pd->lock in padata_reorder. Pairs with smp_mb + * in padata_reorder. + */ + smp_mb__after_atomic(); + +- put_cpu(); +- + padata_reorder(pd); + } + EXPORT_SYMBOL(padata_do_serial); +@@ -413,9 +387,14 @@ static void padata_init_pqueues(struct parallel_data *pd) + struct padata_parallel_queue *pqueue; + + cpu_index = 0; +- for_each_cpu(cpu, pd->cpumask.pcpu) { ++ for_each_possible_cpu(cpu) { + pqueue = per_cpu_ptr(pd->pqueue, cpu); +- pqueue->pd = pd; ++ ++ if (!cpumask_test_cpu(cpu, pd->cpumask.pcpu)) { ++ pqueue->cpu_index = -1; ++ continue; ++ } ++ + pqueue->cpu_index = cpu_index; + cpu_index++; + +@@ -449,12 +428,13 @@ static struct parallel_data *padata_alloc_pd(struct padata_instance *pinst, + + padata_init_pqueues(pd); + padata_init_squeues(pd); +- setup_timer(&pd->timer, padata_reorder_timer, (unsigned long)pd); + atomic_set(&pd->seq_nr, -1); + atomic_set(&pd->reorder_objects, 0); + atomic_set(&pd->refcnt, 1); + pd->pinst = pinst; + spin_lock_init(&pd->lock); ++ pd->cpu = cpumask_first(pd->cpumask.pcpu); ++ INIT_WORK(&pd->reorder_work, invoke_padata_reorder); + + return pd; + +diff --git a/lib/Makefile b/lib/Makefile +index 452d2956a5a2..7a55c5205281 100644 +--- a/lib/Makefile ++++ b/lib/Makefile +@@ -230,5 +230,7 @@ obj-$(CONFIG_UCS2_STRING) += ucs2_string.o + obj-$(CONFIG_UBSAN) += ubsan.o + + UBSAN_SANITIZE_ubsan.o := n ++KASAN_SANITIZE_ubsan.o := n ++CFLAGS_ubsan.o := $(call cc-option, -fno-stack-protector) $(DISABLE_STACKLEAK_PLUGIN) + + obj-$(CONFIG_SBITMAP) += sbitmap.o +diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c +index 7c3da29fad8e..36c7f616294a 100644 +--- a/net/l2tp/l2tp_core.c ++++ b/net/l2tp/l2tp_core.c +@@ -112,53 +112,19 @@ struct l2tp_net { + spinlock_t l2tp_session_hlist_lock; + }; + +-static void l2tp_tunnel_free(struct l2tp_tunnel *tunnel); + + static inline struct l2tp_tunnel *l2tp_tunnel(struct sock *sk) + { + return sk->sk_user_data; + } + +-static inline struct l2tp_net *l2tp_pernet(struct net *net) ++static inline struct l2tp_net *l2tp_pernet(const struct net *net) + { + BUG_ON(!net); + + return net_generic(net, l2tp_net_id); + } + +-/* Tunnel reference counts. Incremented per session that is added to +- * the tunnel. +- */ +-static inline void l2tp_tunnel_inc_refcount_1(struct l2tp_tunnel *tunnel) +-{ +- atomic_inc(&tunnel->ref_count); +-} +- +-static inline void l2tp_tunnel_dec_refcount_1(struct l2tp_tunnel *tunnel) +-{ +- if (atomic_dec_and_test(&tunnel->ref_count)) +- l2tp_tunnel_free(tunnel); +-} +-#ifdef L2TP_REFCNT_DEBUG +-#define l2tp_tunnel_inc_refcount(_t) \ +-do { \ +- pr_debug("l2tp_tunnel_inc_refcount: %s:%d %s: cnt=%d\n", \ +- __func__, __LINE__, (_t)->name, \ +- atomic_read(&_t->ref_count)); \ +- l2tp_tunnel_inc_refcount_1(_t); \ +-} while (0) +-#define l2tp_tunnel_dec_refcount(_t) \ +-do { \ +- pr_debug("l2tp_tunnel_dec_refcount: %s:%d %s: cnt=%d\n", \ +- __func__, __LINE__, (_t)->name, \ +- atomic_read(&_t->ref_count)); \ +- l2tp_tunnel_dec_refcount_1(_t); \ +-} while (0) +-#else +-#define l2tp_tunnel_inc_refcount(t) l2tp_tunnel_inc_refcount_1(t) +-#define l2tp_tunnel_dec_refcount(t) l2tp_tunnel_dec_refcount_1(t) +-#endif +- + /* Session hash global list for L2TPv3. + * The session_id SHOULD be random according to RFC3931, but several + * L2TP implementations use incrementing session_ids. So we do a real +@@ -216,27 +182,6 @@ static void l2tp_tunnel_sock_put(struct sock *sk) + sock_put(sk); + } + +-/* Lookup a session by id in the global session list +- */ +-static struct l2tp_session *l2tp_session_find_2(struct net *net, u32 session_id) +-{ +- struct l2tp_net *pn = l2tp_pernet(net); +- struct hlist_head *session_list = +- l2tp_session_id_hash_2(pn, session_id); +- struct l2tp_session *session; +- +- rcu_read_lock_bh(); +- hlist_for_each_entry_rcu(session, session_list, global_hlist) { +- if (session->session_id == session_id) { +- rcu_read_unlock_bh(); +- return session; +- } +- } +- rcu_read_unlock_bh(); +- +- return NULL; +-} +- + /* Session hash list. + * The session_id SHOULD be random according to RFC2661, but several + * L2TP implementations (Cisco and Microsoft) use incrementing +@@ -249,38 +194,31 @@ l2tp_session_id_hash(struct l2tp_tunnel *tunnel, u32 session_id) + return &tunnel->session_hlist[hash_32(session_id, L2TP_HASH_BITS)]; + } + +-/* Lookup a session by id +- */ +-struct l2tp_session *l2tp_session_find(struct net *net, struct l2tp_tunnel *tunnel, u32 session_id) ++/* Lookup a tunnel. A new reference is held on the returned tunnel. */ ++struct l2tp_tunnel *l2tp_tunnel_get(const struct net *net, u32 tunnel_id) + { +- struct hlist_head *session_list; +- struct l2tp_session *session; ++ const struct l2tp_net *pn = l2tp_pernet(net); ++ struct l2tp_tunnel *tunnel; + +- /* In L2TPv3, session_ids are unique over all tunnels and we +- * sometimes need to look them up before we know the +- * tunnel. +- */ +- if (tunnel == NULL) +- return l2tp_session_find_2(net, session_id); ++ rcu_read_lock_bh(); ++ list_for_each_entry_rcu(tunnel, &pn->l2tp_tunnel_list, list) { ++ if (tunnel->tunnel_id == tunnel_id) { ++ l2tp_tunnel_inc_refcount(tunnel); ++ rcu_read_unlock_bh(); + +- session_list = l2tp_session_id_hash(tunnel, session_id); +- read_lock_bh(&tunnel->hlist_lock); +- hlist_for_each_entry(session, session_list, hlist) { +- if (session->session_id == session_id) { +- read_unlock_bh(&tunnel->hlist_lock); +- return session; ++ return tunnel; + } + } +- read_unlock_bh(&tunnel->hlist_lock); ++ rcu_read_unlock_bh(); + + return NULL; + } +-EXPORT_SYMBOL_GPL(l2tp_session_find); ++EXPORT_SYMBOL_GPL(l2tp_tunnel_get); + +-/* Like l2tp_session_find() but takes a reference on the returned session. ++/* Lookup a session. A new reference is held on the returned session. + * Optionally calls session->ref() too if do_ref is true. + */ +-struct l2tp_session *l2tp_session_get(struct net *net, ++struct l2tp_session *l2tp_session_get(const struct net *net, + struct l2tp_tunnel *tunnel, + u32 session_id, bool do_ref) + { +@@ -355,7 +293,8 @@ EXPORT_SYMBOL_GPL(l2tp_session_get_nth); + /* Lookup a session by interface name. + * This is very inefficient but is only used by management interfaces. + */ +-struct l2tp_session *l2tp_session_get_by_ifname(struct net *net, char *ifname, ++struct l2tp_session *l2tp_session_get_by_ifname(const struct net *net, ++ const char *ifname, + bool do_ref) + { + struct l2tp_net *pn = l2tp_pernet(net); +@@ -382,20 +321,28 @@ struct l2tp_session *l2tp_session_get_by_ifname(struct net *net, char *ifname, + } + EXPORT_SYMBOL_GPL(l2tp_session_get_by_ifname); + +-static int l2tp_session_add_to_tunnel(struct l2tp_tunnel *tunnel, +- struct l2tp_session *session) ++int l2tp_session_register(struct l2tp_session *session, ++ struct l2tp_tunnel *tunnel) + { + struct l2tp_session *session_walk; + struct hlist_head *g_head; + struct hlist_head *head; + struct l2tp_net *pn; ++ int err; + + head = l2tp_session_id_hash(tunnel, session->session_id); + + write_lock_bh(&tunnel->hlist_lock); ++ if (!tunnel->acpt_newsess) { ++ err = -ENODEV; ++ goto err_tlock; ++ } ++ + hlist_for_each_entry(session_walk, head, hlist) +- if (session_walk->session_id == session->session_id) +- goto exist; ++ if (session_walk->session_id == session->session_id) { ++ err = -EEXIST; ++ goto err_tlock; ++ } + + if (tunnel->version == L2TP_HDR_VER_3) { + pn = l2tp_pernet(tunnel->l2tp_net); +@@ -403,30 +350,44 @@ static int l2tp_session_add_to_tunnel(struct l2tp_tunnel *tunnel, + session->session_id); + + spin_lock_bh(&pn->l2tp_session_hlist_lock); ++ + hlist_for_each_entry(session_walk, g_head, global_hlist) +- if (session_walk->session_id == session->session_id) +- goto exist_glob; ++ if (session_walk->session_id == session->session_id) { ++ err = -EEXIST; ++ goto err_tlock_pnlock; ++ } + ++ l2tp_tunnel_inc_refcount(tunnel); ++ sock_hold(tunnel->sock); + hlist_add_head_rcu(&session->global_hlist, g_head); ++ + spin_unlock_bh(&pn->l2tp_session_hlist_lock); ++ } else { ++ l2tp_tunnel_inc_refcount(tunnel); ++ sock_hold(tunnel->sock); + } + + hlist_add_head(&session->hlist, head); + write_unlock_bh(&tunnel->hlist_lock); + ++ /* Ignore management session in session count value */ ++ if (session->session_id != 0) ++ atomic_inc(&l2tp_session_count); ++ + return 0; + +-exist_glob: ++err_tlock_pnlock: + spin_unlock_bh(&pn->l2tp_session_hlist_lock); +-exist: ++err_tlock: + write_unlock_bh(&tunnel->hlist_lock); + +- return -EEXIST; ++ return err; + } ++EXPORT_SYMBOL_GPL(l2tp_session_register); + + /* Lookup a tunnel by id + */ +-struct l2tp_tunnel *l2tp_tunnel_find(struct net *net, u32 tunnel_id) ++struct l2tp_tunnel *l2tp_tunnel_find(const struct net *net, u32 tunnel_id) + { + struct l2tp_tunnel *tunnel; + struct l2tp_net *pn = l2tp_pernet(net); +@@ -444,7 +405,7 @@ struct l2tp_tunnel *l2tp_tunnel_find(struct net *net, u32 tunnel_id) + } + EXPORT_SYMBOL_GPL(l2tp_tunnel_find); + +-struct l2tp_tunnel *l2tp_tunnel_find_nth(struct net *net, int nth) ++struct l2tp_tunnel *l2tp_tunnel_find_nth(const struct net *net, int nth) + { + struct l2tp_net *pn = l2tp_pernet(net); + struct l2tp_tunnel *tunnel; +@@ -1307,7 +1268,6 @@ static void l2tp_tunnel_destruct(struct sock *sk) + /* Remove hooks into tunnel socket */ + sk->sk_destruct = tunnel->old_sk_destruct; + sk->sk_user_data = NULL; +- tunnel->sock = NULL; + + /* Remove the tunnel struct from the tunnel list */ + pn = l2tp_pernet(tunnel->l2tp_net); +@@ -1317,6 +1277,8 @@ static void l2tp_tunnel_destruct(struct sock *sk) + atomic_dec(&l2tp_tunnel_count); + + l2tp_tunnel_closeall(tunnel); ++ ++ tunnel->sock = NULL; + l2tp_tunnel_dec_refcount(tunnel); + + /* Call the original destructor */ +@@ -1341,6 +1303,7 @@ void l2tp_tunnel_closeall(struct l2tp_tunnel *tunnel) + tunnel->name); + + write_lock_bh(&tunnel->hlist_lock); ++ tunnel->acpt_newsess = false; + for (hash = 0; hash < L2TP_HASH_SIZE; hash++) { + again: + hlist_for_each_safe(walk, tmp, &tunnel->session_hlist[hash]) { +@@ -1394,17 +1357,6 @@ static void l2tp_udp_encap_destroy(struct sock *sk) + } + } + +-/* Really kill the tunnel. +- * Come here only when all sessions have been cleared from the tunnel. +- */ +-static void l2tp_tunnel_free(struct l2tp_tunnel *tunnel) +-{ +- BUG_ON(atomic_read(&tunnel->ref_count) != 0); +- BUG_ON(tunnel->sock != NULL); +- l2tp_info(tunnel, L2TP_MSG_CONTROL, "%s: free...\n", tunnel->name); +- kfree_rcu(tunnel, rcu); +-} +- + /* Workqueue tunnel deletion function */ + static void l2tp_tunnel_del_work(struct work_struct *work) + { +@@ -1655,6 +1607,7 @@ int l2tp_tunnel_create(struct net *net, int fd, int version, u32 tunnel_id, u32 + tunnel->magic = L2TP_TUNNEL_MAGIC; + sprintf(&tunnel->name[0], "tunl %u", tunnel_id); + rwlock_init(&tunnel->hlist_lock); ++ tunnel->acpt_newsess = true; + + /* The net we belong to */ + tunnel->l2tp_net = net; +@@ -1840,7 +1793,6 @@ EXPORT_SYMBOL_GPL(l2tp_session_set_header_len); + struct l2tp_session *l2tp_session_create(int priv_size, struct l2tp_tunnel *tunnel, u32 session_id, u32 peer_session_id, struct l2tp_session_cfg *cfg) + { + struct l2tp_session *session; +- int err; + + session = kzalloc(sizeof(struct l2tp_session) + priv_size, GFP_KERNEL); + if (session != NULL) { +@@ -1895,25 +1847,7 @@ struct l2tp_session *l2tp_session_create(int priv_size, struct l2tp_tunnel *tunn + + l2tp_session_set_header_len(session, tunnel->version); + +- err = l2tp_session_add_to_tunnel(tunnel, session); +- if (err) { +- kfree(session); +- +- return ERR_PTR(err); +- } +- +- /* Bump the reference count. The session context is deleted +- * only when this drops to zero. +- */ + l2tp_session_inc_refcount(session); +- l2tp_tunnel_inc_refcount(tunnel); +- +- /* Ensure tunnel socket isn't deleted */ +- sock_hold(tunnel->sock); +- +- /* Ignore management session in session count value */ +- if (session->session_id != 0) +- atomic_inc(&l2tp_session_count); + + return session; + } +diff --git a/net/l2tp/l2tp_core.h b/net/l2tp/l2tp_core.h +index 7c2037184b6c..2b9b6fb67ae9 100644 +--- a/net/l2tp/l2tp_core.h ++++ b/net/l2tp/l2tp_core.h +@@ -23,16 +23,6 @@ + #define L2TP_HASH_BITS_2 8 + #define L2TP_HASH_SIZE_2 (1 << L2TP_HASH_BITS_2) + +-/* Debug message categories for the DEBUG socket option */ +-enum { +- L2TP_MSG_DEBUG = (1 << 0), /* verbose debug (if +- * compiled in) */ +- L2TP_MSG_CONTROL = (1 << 1), /* userspace - kernel +- * interface */ +- L2TP_MSG_SEQ = (1 << 2), /* sequence numbers */ +- L2TP_MSG_DATA = (1 << 3), /* data packets */ +-}; +- + struct sk_buff; + + struct l2tp_stats { +@@ -172,6 +162,10 @@ struct l2tp_tunnel { + + struct rcu_head rcu; + rwlock_t hlist_lock; /* protect session_hlist */ ++ bool acpt_newsess; /* Indicates whether this ++ * tunnel accepts new sessions. ++ * Protected by hlist_lock. ++ */ + struct hlist_head session_hlist[L2TP_HASH_SIZE]; + /* hashed list of sessions, + * hashed by id */ +@@ -207,7 +201,9 @@ struct l2tp_tunnel { + }; + + struct l2tp_nl_cmd_ops { +- int (*session_create)(struct net *net, u32 tunnel_id, u32 session_id, u32 peer_session_id, struct l2tp_session_cfg *cfg); ++ int (*session_create)(struct net *net, struct l2tp_tunnel *tunnel, ++ u32 session_id, u32 peer_session_id, ++ struct l2tp_session_cfg *cfg); + int (*session_delete)(struct l2tp_session *session); + }; + +@@ -241,18 +237,18 @@ out: + return tunnel; + } + +-struct l2tp_session *l2tp_session_get(struct net *net, ++struct l2tp_tunnel *l2tp_tunnel_get(const struct net *net, u32 tunnel_id); ++ ++struct l2tp_session *l2tp_session_get(const struct net *net, + struct l2tp_tunnel *tunnel, + u32 session_id, bool do_ref); +-struct l2tp_session *l2tp_session_find(struct net *net, +- struct l2tp_tunnel *tunnel, +- u32 session_id); + struct l2tp_session *l2tp_session_get_nth(struct l2tp_tunnel *tunnel, int nth, + bool do_ref); +-struct l2tp_session *l2tp_session_get_by_ifname(struct net *net, char *ifname, ++struct l2tp_session *l2tp_session_get_by_ifname(const struct net *net, ++ const char *ifname, + bool do_ref); +-struct l2tp_tunnel *l2tp_tunnel_find(struct net *net, u32 tunnel_id); +-struct l2tp_tunnel *l2tp_tunnel_find_nth(struct net *net, int nth); ++struct l2tp_tunnel *l2tp_tunnel_find(const struct net *net, u32 tunnel_id); ++struct l2tp_tunnel *l2tp_tunnel_find_nth(const struct net *net, int nth); + + int l2tp_tunnel_create(struct net *net, int fd, int version, u32 tunnel_id, + u32 peer_tunnel_id, struct l2tp_tunnel_cfg *cfg, +@@ -263,6 +259,9 @@ struct l2tp_session *l2tp_session_create(int priv_size, + struct l2tp_tunnel *tunnel, + u32 session_id, u32 peer_session_id, + struct l2tp_session_cfg *cfg); ++int l2tp_session_register(struct l2tp_session *session, ++ struct l2tp_tunnel *tunnel); ++ + void __l2tp_session_unhash(struct l2tp_session *session); + int l2tp_session_delete(struct l2tp_session *session); + void l2tp_session_free(struct l2tp_session *session); +@@ -281,6 +280,17 @@ int l2tp_nl_register_ops(enum l2tp_pwtype pw_type, + void l2tp_nl_unregister_ops(enum l2tp_pwtype pw_type); + int l2tp_ioctl(struct sock *sk, int cmd, unsigned long arg); + ++static inline void l2tp_tunnel_inc_refcount(struct l2tp_tunnel *tunnel) ++{ ++ atomic_inc(&tunnel->ref_count); ++} ++ ++static inline void l2tp_tunnel_dec_refcount(struct l2tp_tunnel *tunnel) ++{ ++ if (atomic_dec_and_test(&tunnel->ref_count)) ++ kfree_rcu(tunnel, rcu); ++} ++ + /* Session reference counts. Incremented when code obtains a reference + * to a session. + */ +diff --git a/net/l2tp/l2tp_eth.c b/net/l2tp/l2tp_eth.c +index eecc64e138de..8b8fc2337960 100644 +--- a/net/l2tp/l2tp_eth.c ++++ b/net/l2tp/l2tp_eth.c +@@ -30,6 +30,9 @@ + #include <net/xfrm.h> + #include <net/net_namespace.h> + #include <net/netns/generic.h> ++#include <linux/ip.h> ++#include <linux/ipv6.h> ++#include <linux/udp.h> + + #include "l2tp_core.h" + +@@ -41,7 +44,6 @@ struct l2tp_eth { + struct net_device *dev; + struct sock *tunnel_sock; + struct l2tp_session *session; +- struct list_head list; + atomic_long_t tx_bytes; + atomic_long_t tx_packets; + atomic_long_t tx_dropped; +@@ -52,20 +54,9 @@ struct l2tp_eth { + + /* via l2tp_session_priv() */ + struct l2tp_eth_sess { +- struct net_device *dev; ++ struct net_device __rcu *dev; + }; + +-/* per-net private data for this module */ +-static unsigned int l2tp_eth_net_id; +-struct l2tp_eth_net { +- struct list_head l2tp_eth_dev_list; +- spinlock_t l2tp_eth_lock; +-}; +- +-static inline struct l2tp_eth_net *l2tp_eth_pernet(struct net *net) +-{ +- return net_generic(net, l2tp_eth_net_id); +-} + + static int l2tp_eth_dev_init(struct net_device *dev) + { +@@ -82,12 +73,13 @@ static int l2tp_eth_dev_init(struct net_device *dev) + static void l2tp_eth_dev_uninit(struct net_device *dev) + { + struct l2tp_eth *priv = netdev_priv(dev); +- struct l2tp_eth_net *pn = l2tp_eth_pernet(dev_net(dev)); ++ struct l2tp_eth_sess *spriv; + +- spin_lock(&pn->l2tp_eth_lock); +- list_del_init(&priv->list); +- spin_unlock(&pn->l2tp_eth_lock); +- dev_put(dev); ++ spriv = l2tp_session_priv(priv->session); ++ RCU_INIT_POINTER(spriv->dev, NULL); ++ /* No need for synchronize_net() here. We're called by ++ * unregister_netdev*(), which does the synchronisation for us. ++ */ + } + + static int l2tp_eth_dev_xmit(struct sk_buff *skb, struct net_device *dev) +@@ -141,8 +133,8 @@ static void l2tp_eth_dev_setup(struct net_device *dev) + static void l2tp_eth_dev_recv(struct l2tp_session *session, struct sk_buff *skb, int data_len) + { + struct l2tp_eth_sess *spriv = l2tp_session_priv(session); +- struct net_device *dev = spriv->dev; +- struct l2tp_eth *priv = netdev_priv(dev); ++ struct net_device *dev; ++ struct l2tp_eth *priv; + + if (session->debug & L2TP_MSG_DATA) { + unsigned int length; +@@ -166,16 +158,25 @@ static void l2tp_eth_dev_recv(struct l2tp_session *session, struct sk_buff *skb, + skb_dst_drop(skb); + nf_reset(skb); + ++ rcu_read_lock(); ++ dev = rcu_dereference(spriv->dev); ++ if (!dev) ++ goto error_rcu; ++ ++ priv = netdev_priv(dev); + if (dev_forward_skb(dev, skb) == NET_RX_SUCCESS) { + atomic_long_inc(&priv->rx_packets); + atomic_long_add(data_len, &priv->rx_bytes); + } else { + atomic_long_inc(&priv->rx_errors); + } ++ rcu_read_unlock(); ++ + return; + ++error_rcu: ++ rcu_read_unlock(); + error: +- atomic_long_inc(&priv->rx_errors); + kfree_skb(skb); + } + +@@ -186,11 +187,15 @@ static void l2tp_eth_delete(struct l2tp_session *session) + + if (session) { + spriv = l2tp_session_priv(session); +- dev = spriv->dev; ++ ++ rtnl_lock(); ++ dev = rtnl_dereference(spriv->dev); + if (dev) { +- unregister_netdev(dev); +- spriv->dev = NULL; ++ unregister_netdevice(dev); ++ rtnl_unlock(); + module_put(THIS_MODULE); ++ } else { ++ rtnl_unlock(); + } + } + } +@@ -200,35 +205,89 @@ static void l2tp_eth_show(struct seq_file *m, void *arg) + { + struct l2tp_session *session = arg; + struct l2tp_eth_sess *spriv = l2tp_session_priv(session); +- struct net_device *dev = spriv->dev; ++ struct net_device *dev; ++ ++ rcu_read_lock(); ++ dev = rcu_dereference(spriv->dev); ++ if (!dev) { ++ rcu_read_unlock(); ++ return; ++ } ++ dev_hold(dev); ++ rcu_read_unlock(); + + seq_printf(m, " interface %s\n", dev->name); ++ ++ dev_put(dev); + } + #endif + +-static int l2tp_eth_create(struct net *net, u32 tunnel_id, u32 session_id, u32 peer_session_id, struct l2tp_session_cfg *cfg) ++static void l2tp_eth_adjust_mtu(struct l2tp_tunnel *tunnel, ++ struct l2tp_session *session, ++ struct net_device *dev) ++{ ++ unsigned int overhead = 0; ++ struct dst_entry *dst; ++ u32 l3_overhead = 0; ++ ++ /* if the encap is UDP, account for UDP header size */ ++ if (tunnel->encap == L2TP_ENCAPTYPE_UDP) { ++ overhead += sizeof(struct udphdr); ++ dev->needed_headroom += sizeof(struct udphdr); ++ } ++ if (session->mtu != 0) { ++ dev->mtu = session->mtu; ++ dev->needed_headroom += session->hdr_len; ++ return; ++ } ++ lock_sock(tunnel->sock); ++ l3_overhead = kernel_sock_ip_overhead(tunnel->sock); ++ release_sock(tunnel->sock); ++ if (l3_overhead == 0) { ++ /* L3 Overhead couldn't be identified, this could be ++ * because tunnel->sock was NULL or the socket's ++ * address family was not IPv4 or IPv6, ++ * dev mtu stays at 1500. ++ */ ++ return; ++ } ++ /* Adjust MTU, factor overhead - underlay L3, overlay L2 hdr ++ * UDP overhead, if any, was already factored in above. ++ */ ++ overhead += session->hdr_len + ETH_HLEN + l3_overhead; ++ ++ /* If PMTU discovery was enabled, use discovered MTU on L2TP device */ ++ dst = sk_dst_get(tunnel->sock); ++ if (dst) { ++ /* dst_mtu will use PMTU if found, else fallback to intf MTU */ ++ u32 pmtu = dst_mtu(dst); ++ ++ if (pmtu != 0) ++ dev->mtu = pmtu; ++ dst_release(dst); ++ } ++ session->mtu = dev->mtu - overhead; ++ dev->mtu = session->mtu; ++ dev->needed_headroom += session->hdr_len; ++} ++ ++static int l2tp_eth_create(struct net *net, struct l2tp_tunnel *tunnel, ++ u32 session_id, u32 peer_session_id, ++ struct l2tp_session_cfg *cfg) + { + struct net_device *dev; + char name[IFNAMSIZ]; +- struct l2tp_tunnel *tunnel; + struct l2tp_session *session; + struct l2tp_eth *priv; + struct l2tp_eth_sess *spriv; + int rc; +- struct l2tp_eth_net *pn; +- +- tunnel = l2tp_tunnel_find(net, tunnel_id); +- if (!tunnel) { +- rc = -ENODEV; +- goto out; +- } + + if (cfg->ifname) { + dev = dev_get_by_name(net, cfg->ifname); + if (dev) { + dev_put(dev); + rc = -EEXIST; +- goto out; ++ goto err; + } + strlcpy(name, cfg->ifname, IFNAMSIZ); + } else +@@ -238,26 +297,22 @@ static int l2tp_eth_create(struct net *net, u32 tunnel_id, u32 session_id, u32 p + peer_session_id, cfg); + if (IS_ERR(session)) { + rc = PTR_ERR(session); +- goto out; ++ goto err; + } + + dev = alloc_netdev(sizeof(*priv), name, NET_NAME_UNKNOWN, + l2tp_eth_dev_setup); + if (!dev) { + rc = -ENOMEM; +- goto out_del_session; ++ goto err_sess; + } + + dev_net_set(dev, net); +- if (session->mtu == 0) +- session->mtu = dev->mtu - session->hdr_len; +- dev->mtu = session->mtu; +- dev->needed_headroom += session->hdr_len; ++ l2tp_eth_adjust_mtu(tunnel, session, dev); + + priv = netdev_priv(dev); + priv->dev = dev; + priv->session = session; +- INIT_LIST_HEAD(&priv->list); + + priv->tunnel_sock = tunnel->sock; + session->recv_skb = l2tp_eth_dev_recv; +@@ -267,48 +322,50 @@ static int l2tp_eth_create(struct net *net, u32 tunnel_id, u32 session_id, u32 p + #endif + + spriv = l2tp_session_priv(session); +- spriv->dev = dev; + +- rc = register_netdev(dev); +- if (rc < 0) +- goto out_del_dev; ++ l2tp_session_inc_refcount(session); + +- __module_get(THIS_MODULE); +- /* Must be done after register_netdev() */ +- strlcpy(session->ifname, dev->name, IFNAMSIZ); ++ rtnl_lock(); + +- dev_hold(dev); +- pn = l2tp_eth_pernet(dev_net(dev)); +- spin_lock(&pn->l2tp_eth_lock); +- list_add(&priv->list, &pn->l2tp_eth_dev_list); +- spin_unlock(&pn->l2tp_eth_lock); ++ /* Register both device and session while holding the rtnl lock. This ++ * ensures that l2tp_eth_delete() will see that there's a device to ++ * unregister, even if it happened to run before we assign spriv->dev. ++ */ ++ rc = l2tp_session_register(session, tunnel); ++ if (rc < 0) { ++ rtnl_unlock(); ++ goto err_sess_dev; ++ } + +- return 0; ++ rc = register_netdevice(dev); ++ if (rc < 0) { ++ rtnl_unlock(); ++ l2tp_session_delete(session); ++ l2tp_session_dec_refcount(session); ++ free_netdev(dev); + +-out_del_dev: +- free_netdev(dev); +- spriv->dev = NULL; +-out_del_session: +- l2tp_session_delete(session); +-out: +- return rc; +-} ++ return rc; ++ } + +-static __net_init int l2tp_eth_init_net(struct net *net) +-{ +- struct l2tp_eth_net *pn = net_generic(net, l2tp_eth_net_id); ++ strlcpy(session->ifname, dev->name, IFNAMSIZ); ++ rcu_assign_pointer(spriv->dev, dev); ++ ++ rtnl_unlock(); + +- INIT_LIST_HEAD(&pn->l2tp_eth_dev_list); +- spin_lock_init(&pn->l2tp_eth_lock); ++ l2tp_session_dec_refcount(session); ++ ++ __module_get(THIS_MODULE); + + return 0; +-} + +-static struct pernet_operations l2tp_eth_net_ops = { +- .init = l2tp_eth_init_net, +- .id = &l2tp_eth_net_id, +- .size = sizeof(struct l2tp_eth_net), +-}; ++err_sess_dev: ++ l2tp_session_dec_refcount(session); ++ free_netdev(dev); ++err_sess: ++ kfree(session); ++err: ++ return rc; ++} + + + static const struct l2tp_nl_cmd_ops l2tp_eth_nl_cmd_ops = { +@@ -323,25 +380,18 @@ static int __init l2tp_eth_init(void) + + err = l2tp_nl_register_ops(L2TP_PWTYPE_ETH, &l2tp_eth_nl_cmd_ops); + if (err) +- goto out; +- +- err = register_pernet_device(&l2tp_eth_net_ops); +- if (err) +- goto out_unreg; ++ goto err; + + pr_info("L2TP ethernet pseudowire support (L2TPv3)\n"); + + return 0; + +-out_unreg: +- l2tp_nl_unregister_ops(L2TP_PWTYPE_ETH); +-out: ++err: + return err; + } + + static void __exit l2tp_eth_exit(void) + { +- unregister_pernet_device(&l2tp_eth_net_ops); + l2tp_nl_unregister_ops(L2TP_PWTYPE_ETH); + } + +diff --git a/net/l2tp/l2tp_netlink.c b/net/l2tp/l2tp_netlink.c +index d6fccfdca201..47d7bdff8be8 100644 +--- a/net/l2tp/l2tp_netlink.c ++++ b/net/l2tp/l2tp_netlink.c +@@ -72,10 +72,12 @@ static struct l2tp_session *l2tp_nl_session_get(struct genl_info *info, + (info->attrs[L2TP_ATTR_CONN_ID])) { + tunnel_id = nla_get_u32(info->attrs[L2TP_ATTR_CONN_ID]); + session_id = nla_get_u32(info->attrs[L2TP_ATTR_SESSION_ID]); +- tunnel = l2tp_tunnel_find(net, tunnel_id); +- if (tunnel) ++ tunnel = l2tp_tunnel_get(net, tunnel_id); ++ if (tunnel) { + session = l2tp_session_get(net, tunnel, session_id, + do_ref); ++ l2tp_tunnel_dec_refcount(tunnel); ++ } + } + + return session; +@@ -278,8 +280,8 @@ static int l2tp_nl_cmd_tunnel_delete(struct sk_buff *skb, struct genl_info *info + } + tunnel_id = nla_get_u32(info->attrs[L2TP_ATTR_CONN_ID]); + +- tunnel = l2tp_tunnel_find(net, tunnel_id); +- if (tunnel == NULL) { ++ tunnel = l2tp_tunnel_get(net, tunnel_id); ++ if (!tunnel) { + ret = -ENODEV; + goto out; + } +@@ -289,6 +291,8 @@ static int l2tp_nl_cmd_tunnel_delete(struct sk_buff *skb, struct genl_info *info + + l2tp_tunnel_delete(tunnel); + ++ l2tp_tunnel_dec_refcount(tunnel); ++ + out: + return ret; + } +@@ -306,8 +310,8 @@ static int l2tp_nl_cmd_tunnel_modify(struct sk_buff *skb, struct genl_info *info + } + tunnel_id = nla_get_u32(info->attrs[L2TP_ATTR_CONN_ID]); + +- tunnel = l2tp_tunnel_find(net, tunnel_id); +- if (tunnel == NULL) { ++ tunnel = l2tp_tunnel_get(net, tunnel_id); ++ if (!tunnel) { + ret = -ENODEV; + goto out; + } +@@ -318,6 +322,8 @@ static int l2tp_nl_cmd_tunnel_modify(struct sk_buff *skb, struct genl_info *info + ret = l2tp_tunnel_notify(&l2tp_nl_family, info, + tunnel, L2TP_CMD_TUNNEL_MODIFY); + ++ l2tp_tunnel_dec_refcount(tunnel); ++ + out: + return ret; + } +@@ -430,34 +436,37 @@ static int l2tp_nl_cmd_tunnel_get(struct sk_buff *skb, struct genl_info *info) + + if (!info->attrs[L2TP_ATTR_CONN_ID]) { + ret = -EINVAL; +- goto out; ++ goto err; + } + + tunnel_id = nla_get_u32(info->attrs[L2TP_ATTR_CONN_ID]); + +- tunnel = l2tp_tunnel_find(net, tunnel_id); +- if (tunnel == NULL) { +- ret = -ENODEV; +- goto out; +- } +- + msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL); + if (!msg) { + ret = -ENOMEM; +- goto out; ++ goto err; ++ } ++ ++ tunnel = l2tp_tunnel_get(net, tunnel_id); ++ if (!tunnel) { ++ ret = -ENODEV; ++ goto err_nlmsg; + } + + ret = l2tp_nl_tunnel_send(msg, info->snd_portid, info->snd_seq, + NLM_F_ACK, tunnel, L2TP_CMD_TUNNEL_GET); + if (ret < 0) +- goto err_out; ++ goto err_nlmsg_tunnel; ++ ++ l2tp_tunnel_dec_refcount(tunnel); + + return genlmsg_unicast(net, msg, info->snd_portid); + +-err_out: ++err_nlmsg_tunnel: ++ l2tp_tunnel_dec_refcount(tunnel); ++err_nlmsg: + nlmsg_free(msg); +- +-out: ++err: + return ret; + } + +@@ -501,8 +510,9 @@ static int l2tp_nl_cmd_session_create(struct sk_buff *skb, struct genl_info *inf + ret = -EINVAL; + goto out; + } ++ + tunnel_id = nla_get_u32(info->attrs[L2TP_ATTR_CONN_ID]); +- tunnel = l2tp_tunnel_find(net, tunnel_id); ++ tunnel = l2tp_tunnel_get(net, tunnel_id); + if (!tunnel) { + ret = -ENODEV; + goto out; +@@ -510,29 +520,24 @@ static int l2tp_nl_cmd_session_create(struct sk_buff *skb, struct genl_info *inf + + if (!info->attrs[L2TP_ATTR_SESSION_ID]) { + ret = -EINVAL; +- goto out; ++ goto out_tunnel; + } + session_id = nla_get_u32(info->attrs[L2TP_ATTR_SESSION_ID]); +- session = l2tp_session_find(net, tunnel, session_id); +- if (session) { +- ret = -EEXIST; +- goto out; +- } + + if (!info->attrs[L2TP_ATTR_PEER_SESSION_ID]) { + ret = -EINVAL; +- goto out; ++ goto out_tunnel; + } + peer_session_id = nla_get_u32(info->attrs[L2TP_ATTR_PEER_SESSION_ID]); + + if (!info->attrs[L2TP_ATTR_PW_TYPE]) { + ret = -EINVAL; +- goto out; ++ goto out_tunnel; + } + cfg.pw_type = nla_get_u16(info->attrs[L2TP_ATTR_PW_TYPE]); + if (cfg.pw_type >= __L2TP_PWTYPE_MAX) { + ret = -EINVAL; +- goto out; ++ goto out_tunnel; + } + + if (tunnel->version > 2) { +@@ -551,7 +556,7 @@ static int l2tp_nl_cmd_session_create(struct sk_buff *skb, struct genl_info *inf + u16 len = nla_len(info->attrs[L2TP_ATTR_COOKIE]); + if (len > 8) { + ret = -EINVAL; +- goto out; ++ goto out_tunnel; + } + cfg.cookie_len = len; + memcpy(&cfg.cookie[0], nla_data(info->attrs[L2TP_ATTR_COOKIE]), len); +@@ -560,7 +565,7 @@ static int l2tp_nl_cmd_session_create(struct sk_buff *skb, struct genl_info *inf + u16 len = nla_len(info->attrs[L2TP_ATTR_PEER_COOKIE]); + if (len > 8) { + ret = -EINVAL; +- goto out; ++ goto out_tunnel; + } + cfg.peer_cookie_len = len; + memcpy(&cfg.peer_cookie[0], nla_data(info->attrs[L2TP_ATTR_PEER_COOKIE]), len); +@@ -603,7 +608,7 @@ static int l2tp_nl_cmd_session_create(struct sk_buff *skb, struct genl_info *inf + if ((l2tp_nl_cmd_ops[cfg.pw_type] == NULL) || + (l2tp_nl_cmd_ops[cfg.pw_type]->session_create == NULL)) { + ret = -EPROTONOSUPPORT; +- goto out; ++ goto out_tunnel; + } + + /* Check that pseudowire-specific params are present */ +@@ -613,7 +618,7 @@ static int l2tp_nl_cmd_session_create(struct sk_buff *skb, struct genl_info *inf + case L2TP_PWTYPE_ETH_VLAN: + if (!info->attrs[L2TP_ATTR_VLAN_ID]) { + ret = -EINVAL; +- goto out; ++ goto out_tunnel; + } + break; + case L2TP_PWTYPE_ETH: +@@ -627,10 +632,10 @@ static int l2tp_nl_cmd_session_create(struct sk_buff *skb, struct genl_info *inf + break; + } + +- ret = -EPROTONOSUPPORT; +- if (l2tp_nl_cmd_ops[cfg.pw_type]->session_create) +- ret = (*l2tp_nl_cmd_ops[cfg.pw_type]->session_create)(net, tunnel_id, +- session_id, peer_session_id, &cfg); ++ ret = l2tp_nl_cmd_ops[cfg.pw_type]->session_create(net, tunnel, ++ session_id, ++ peer_session_id, ++ &cfg); + + if (ret >= 0) { + session = l2tp_session_get(net, tunnel, session_id, false); +@@ -641,6 +646,8 @@ static int l2tp_nl_cmd_session_create(struct sk_buff *skb, struct genl_info *inf + } + } + ++out_tunnel: ++ l2tp_tunnel_dec_refcount(tunnel); + out: + return ret; + } +diff --git a/net/l2tp/l2tp_ppp.c b/net/l2tp/l2tp_ppp.c +index d919b3e6b548..979fa868a4f1 100644 +--- a/net/l2tp/l2tp_ppp.c ++++ b/net/l2tp/l2tp_ppp.c +@@ -122,8 +122,11 @@ + struct pppol2tp_session { + int owner; /* pid that opened the socket */ + +- struct sock *sock; /* Pointer to the session ++ struct mutex sk_lock; /* Protects .sk */ ++ struct sock __rcu *sk; /* Pointer to the session + * PPPoX socket */ ++ struct sock *__sk; /* Copy of .sk, for cleanup */ ++ struct rcu_head rcu; /* For asynchronous release */ + struct sock *tunnel_sock; /* Pointer to the tunnel UDP + * socket */ + int flags; /* accessed by PPPIOCGFLAGS. +@@ -138,6 +141,24 @@ static const struct ppp_channel_ops pppol2tp_chan_ops = { + + static const struct proto_ops pppol2tp_ops; + ++/* Retrieves the pppol2tp socket associated to a session. ++ * A reference is held on the returned socket, so this function must be paired ++ * with sock_put(). ++ */ ++static struct sock *pppol2tp_session_get_sock(struct l2tp_session *session) ++{ ++ struct pppol2tp_session *ps = l2tp_session_priv(session); ++ struct sock *sk; ++ ++ rcu_read_lock(); ++ sk = rcu_dereference(ps->sk); ++ if (sk) ++ sock_hold(sk); ++ rcu_read_unlock(); ++ ++ return sk; ++} ++ + /* Helpers to obtain tunnel/session contexts from sockets. + */ + static inline struct l2tp_session *pppol2tp_sock_to_session(struct sock *sk) +@@ -224,21 +245,22 @@ static void pppol2tp_recv(struct l2tp_session *session, struct sk_buff *skb, int + /* If the socket is bound, send it in to PPP's input queue. Otherwise + * queue it on the session socket. + */ +- sk = ps->sock; ++ rcu_read_lock(); ++ sk = rcu_dereference(ps->sk); + if (sk == NULL) + goto no_sock; + + if (sk->sk_state & PPPOX_BOUND) { + struct pppox_sock *po; + +- l2tp_dbg(session, PPPOL2TP_MSG_DATA, ++ l2tp_dbg(session, L2TP_MSG_DATA, + "%s: recv %d byte data frame, passing to ppp\n", + session->name, data_len); + + po = pppox_sk(sk); + ppp_input(&po->chan, skb); + } else { +- l2tp_dbg(session, PPPOL2TP_MSG_DATA, ++ l2tp_dbg(session, L2TP_MSG_DATA, + "%s: recv %d byte data frame, passing to L2TP socket\n", + session->name, data_len); + +@@ -247,30 +269,16 @@ static void pppol2tp_recv(struct l2tp_session *session, struct sk_buff *skb, int + kfree_skb(skb); + } + } ++ rcu_read_unlock(); + + return; + + no_sock: +- l2tp_info(session, PPPOL2TP_MSG_DATA, "%s: no socket\n", session->name); ++ rcu_read_unlock(); ++ l2tp_info(session, L2TP_MSG_DATA, "%s: no socket\n", session->name); + kfree_skb(skb); + } + +-static void pppol2tp_session_sock_hold(struct l2tp_session *session) +-{ +- struct pppol2tp_session *ps = l2tp_session_priv(session); +- +- if (ps->sock) +- sock_hold(ps->sock); +-} +- +-static void pppol2tp_session_sock_put(struct l2tp_session *session) +-{ +- struct pppol2tp_session *ps = l2tp_session_priv(session); +- +- if (ps->sock) +- sock_put(ps->sock); +-} +- + /************************************************************************ + * Transmit handling + ***********************************************************************/ +@@ -431,17 +439,16 @@ abort: + */ + static void pppol2tp_session_close(struct l2tp_session *session) + { +- struct pppol2tp_session *ps = l2tp_session_priv(session); +- struct sock *sk = ps->sock; +- struct socket *sock = sk->sk_socket; ++ struct sock *sk; + + BUG_ON(session->magic != L2TP_SESSION_MAGIC); + +- if (sock) +- inet_shutdown(sock, SEND_SHUTDOWN); +- +- /* Don't let the session go away before our socket does */ +- l2tp_session_inc_refcount(session); ++ sk = pppol2tp_session_get_sock(session); ++ if (sk) { ++ if (sk->sk_socket) ++ inet_shutdown(sk->sk_socket, SEND_SHUTDOWN); ++ sock_put(sk); ++ } + } + + /* Really kill the session socket. (Called from sock_put() if +@@ -461,6 +468,14 @@ static void pppol2tp_session_destruct(struct sock *sk) + } + } + ++static void pppol2tp_put_sk(struct rcu_head *head) ++{ ++ struct pppol2tp_session *ps; ++ ++ ps = container_of(head, typeof(*ps), rcu); ++ sock_put(ps->__sk); ++} ++ + /* Called when the PPPoX socket (session) is closed. + */ + static int pppol2tp_release(struct socket *sock) +@@ -486,11 +501,23 @@ static int pppol2tp_release(struct socket *sock) + + session = pppol2tp_sock_to_session(sk); + +- /* Purge any queued data */ + if (session != NULL) { +- __l2tp_session_unhash(session); +- l2tp_session_queue_purge(session); +- sock_put(sk); ++ struct pppol2tp_session *ps; ++ ++ l2tp_session_delete(session); ++ ++ ps = l2tp_session_priv(session); ++ mutex_lock(&ps->sk_lock); ++ ps->__sk = rcu_dereference_protected(ps->sk, ++ lockdep_is_held(&ps->sk_lock)); ++ RCU_INIT_POINTER(ps->sk, NULL); ++ mutex_unlock(&ps->sk_lock); ++ call_rcu(&ps->rcu, pppol2tp_put_sk); ++ ++ /* Rely on the sock_put() call at the end of the function for ++ * dropping the reference held by pppol2tp_sock_to_session(). ++ * The last reference will be dropped by pppol2tp_put_sk(). ++ */ + } + release_sock(sk); + +@@ -557,16 +584,47 @@ out: + static void pppol2tp_show(struct seq_file *m, void *arg) + { + struct l2tp_session *session = arg; +- struct pppol2tp_session *ps = l2tp_session_priv(session); ++ struct sock *sk; ++ ++ sk = pppol2tp_session_get_sock(session); ++ if (sk) { ++ struct pppox_sock *po = pppox_sk(sk); + +- if (ps) { +- struct pppox_sock *po = pppox_sk(ps->sock); +- if (po) +- seq_printf(m, " interface %s\n", ppp_dev_name(&po->chan)); ++ seq_printf(m, " interface %s\n", ppp_dev_name(&po->chan)); ++ sock_put(sk); + } + } + #endif + ++static void pppol2tp_session_init(struct l2tp_session *session) ++{ ++ struct pppol2tp_session *ps; ++ struct dst_entry *dst; ++ ++ session->recv_skb = pppol2tp_recv; ++ session->session_close = pppol2tp_session_close; ++#if IS_ENABLED(CONFIG_L2TP_DEBUGFS) ++ session->show = pppol2tp_show; ++#endif ++ ++ ps = l2tp_session_priv(session); ++ mutex_init(&ps->sk_lock); ++ ps->tunnel_sock = session->tunnel->sock; ++ ps->owner = current->pid; ++ ++ /* If PMTU discovery was enabled, use the MTU that was discovered */ ++ dst = sk_dst_get(session->tunnel->sock); ++ if (dst) { ++ u32 pmtu = dst_mtu(dst); ++ ++ if (pmtu) { ++ session->mtu = pmtu - PPPOL2TP_HEADER_OVERHEAD; ++ session->mru = pmtu - PPPOL2TP_HEADER_OVERHEAD; ++ } ++ dst_release(dst); ++ } ++} ++ + /* connect() handler. Attach a PPPoX socket to a tunnel UDP socket + */ + static int pppol2tp_connect(struct socket *sock, struct sockaddr *uservaddr, +@@ -578,7 +636,6 @@ static int pppol2tp_connect(struct socket *sock, struct sockaddr *uservaddr, + struct l2tp_session *session = NULL; + struct l2tp_tunnel *tunnel; + struct pppol2tp_session *ps; +- struct dst_entry *dst; + struct l2tp_session_cfg cfg = { 0, }; + int error = 0; + u32 tunnel_id, peer_tunnel_id; +@@ -700,13 +757,17 @@ static int pppol2tp_connect(struct socket *sock, struct sockaddr *uservaddr, + /* Using a pre-existing session is fine as long as it hasn't + * been connected yet. + */ +- if (ps->sock) { ++ mutex_lock(&ps->sk_lock); ++ if (rcu_dereference_protected(ps->sk, ++ lockdep_is_held(&ps->sk_lock))) { ++ mutex_unlock(&ps->sk_lock); + error = -EEXIST; + goto end; + } + + /* consistency checks */ + if (ps->tunnel_sock != tunnel->sock) { ++ mutex_unlock(&ps->sk_lock); + error = -EEXIST; + goto end; + } +@@ -722,35 +783,19 @@ static int pppol2tp_connect(struct socket *sock, struct sockaddr *uservaddr, + error = PTR_ERR(session); + goto end; + } +- } +- +- /* Associate session with its PPPoL2TP socket */ +- ps = l2tp_session_priv(session); +- ps->owner = current->pid; +- ps->sock = sk; +- ps->tunnel_sock = tunnel->sock; + +- session->recv_skb = pppol2tp_recv; +- session->session_close = pppol2tp_session_close; +-#if IS_ENABLED(CONFIG_L2TP_DEBUGFS) +- session->show = pppol2tp_show; +-#endif +- +- /* We need to know each time a skb is dropped from the reorder +- * queue. +- */ +- session->ref = pppol2tp_session_sock_hold; +- session->deref = pppol2tp_session_sock_put; +- +- /* If PMTU discovery was enabled, use the MTU that was discovered */ +- dst = sk_dst_get(tunnel->sock); +- if (dst != NULL) { +- u32 pmtu = dst_mtu(dst); ++ pppol2tp_session_init(session); ++ ps = l2tp_session_priv(session); ++ l2tp_session_inc_refcount(session); + +- if (pmtu != 0) +- session->mtu = session->mru = pmtu - +- PPPOL2TP_HEADER_OVERHEAD; +- dst_release(dst); ++ mutex_lock(&ps->sk_lock); ++ error = l2tp_session_register(session, tunnel); ++ if (error < 0) { ++ mutex_unlock(&ps->sk_lock); ++ kfree(session); ++ goto end; ++ } ++ drop_refcnt = true; + } + + /* Special case: if source & dest session_id == 0x0000, this +@@ -775,14 +820,25 @@ static int pppol2tp_connect(struct socket *sock, struct sockaddr *uservaddr, + po->chan.mtu = session->mtu; + + error = ppp_register_net_channel(sock_net(sk), &po->chan); +- if (error) ++ if (error) { ++ mutex_unlock(&ps->sk_lock); + goto end; ++ } + + out_no_ppp: + /* This is how we get the session context from the socket. */ + sk->sk_user_data = session; ++ rcu_assign_pointer(ps->sk, sk); ++ mutex_unlock(&ps->sk_lock); ++ ++ /* Keep the reference we've grabbed on the session: sk doesn't expect ++ * the session to disappear. pppol2tp_session_destruct() is responsible ++ * for dropping it. ++ */ ++ drop_refcnt = false; ++ + sk->sk_state = PPPOX_CONNECTED; +- l2tp_info(session, PPPOL2TP_MSG_CONTROL, "%s: created\n", ++ l2tp_info(session, L2TP_MSG_CONTROL, "%s: created\n", + session->name); + + end: +@@ -795,25 +851,19 @@ end: + + #ifdef CONFIG_L2TP_V3 + +-/* Called when creating sessions via the netlink interface. +- */ +-static int pppol2tp_session_create(struct net *net, u32 tunnel_id, u32 session_id, u32 peer_session_id, struct l2tp_session_cfg *cfg) ++/* Called when creating sessions via the netlink interface. */ ++static int pppol2tp_session_create(struct net *net, struct l2tp_tunnel *tunnel, ++ u32 session_id, u32 peer_session_id, ++ struct l2tp_session_cfg *cfg) + { + int error; +- struct l2tp_tunnel *tunnel; + struct l2tp_session *session; +- struct pppol2tp_session *ps; +- +- tunnel = l2tp_tunnel_find(net, tunnel_id); +- +- /* Error if we can't find the tunnel */ +- error = -ENOENT; +- if (tunnel == NULL) +- goto out; + + /* Error if tunnel socket is not prepped */ +- if (tunnel->sock == NULL) +- goto out; ++ if (!tunnel->sock) { ++ error = -ENOENT; ++ goto err; ++ } + + /* Default MTU values. */ + if (cfg->mtu == 0) +@@ -827,18 +877,20 @@ static int pppol2tp_session_create(struct net *net, u32 tunnel_id, u32 session_i + peer_session_id, cfg); + if (IS_ERR(session)) { + error = PTR_ERR(session); +- goto out; ++ goto err; + } + +- ps = l2tp_session_priv(session); +- ps->tunnel_sock = tunnel->sock; ++ pppol2tp_session_init(session); + +- l2tp_info(session, PPPOL2TP_MSG_CONTROL, "%s: created\n", +- session->name); ++ error = l2tp_session_register(session, tunnel); ++ if (error < 0) ++ goto err_sess; + +- error = 0; ++ return 0; + +-out: ++err_sess: ++ kfree(session); ++err: + return error; + } + +@@ -995,16 +1047,14 @@ static int pppol2tp_session_ioctl(struct l2tp_session *session, + struct l2tp_tunnel *tunnel = session->tunnel; + struct pppol2tp_ioc_stats stats; + +- l2tp_dbg(session, PPPOL2TP_MSG_CONTROL, ++ l2tp_dbg(session, L2TP_MSG_CONTROL, + "%s: pppol2tp_session_ioctl(cmd=%#x, arg=%#lx)\n", + session->name, cmd, arg); + +- sk = ps->sock; ++ sk = pppol2tp_session_get_sock(session); + if (!sk) + return -EBADR; + +- sock_hold(sk); +- + switch (cmd) { + case SIOCGIFMTU: + err = -ENXIO; +@@ -1018,7 +1068,7 @@ static int pppol2tp_session_ioctl(struct l2tp_session *session, + if (copy_to_user((void __user *) arg, &ifr, sizeof(struct ifreq))) + break; + +- l2tp_info(session, PPPOL2TP_MSG_CONTROL, "%s: get mtu=%d\n", ++ l2tp_info(session, L2TP_MSG_CONTROL, "%s: get mtu=%d\n", + session->name, session->mtu); + err = 0; + break; +@@ -1034,7 +1084,7 @@ static int pppol2tp_session_ioctl(struct l2tp_session *session, + + session->mtu = ifr.ifr_mtu; + +- l2tp_info(session, PPPOL2TP_MSG_CONTROL, "%s: set mtu=%d\n", ++ l2tp_info(session, L2TP_MSG_CONTROL, "%s: set mtu=%d\n", + session->name, session->mtu); + err = 0; + break; +@@ -1048,7 +1098,7 @@ static int pppol2tp_session_ioctl(struct l2tp_session *session, + if (put_user(session->mru, (int __user *) arg)) + break; + +- l2tp_info(session, PPPOL2TP_MSG_CONTROL, "%s: get mru=%d\n", ++ l2tp_info(session, L2TP_MSG_CONTROL, "%s: get mru=%d\n", + session->name, session->mru); + err = 0; + break; +@@ -1063,7 +1113,7 @@ static int pppol2tp_session_ioctl(struct l2tp_session *session, + break; + + session->mru = val; +- l2tp_info(session, PPPOL2TP_MSG_CONTROL, "%s: set mru=%d\n", ++ l2tp_info(session, L2TP_MSG_CONTROL, "%s: set mru=%d\n", + session->name, session->mru); + err = 0; + break; +@@ -1073,7 +1123,7 @@ static int pppol2tp_session_ioctl(struct l2tp_session *session, + if (put_user(ps->flags, (int __user *) arg)) + break; + +- l2tp_info(session, PPPOL2TP_MSG_CONTROL, "%s: get flags=%d\n", ++ l2tp_info(session, L2TP_MSG_CONTROL, "%s: get flags=%d\n", + session->name, ps->flags); + err = 0; + break; +@@ -1083,7 +1133,7 @@ static int pppol2tp_session_ioctl(struct l2tp_session *session, + if (get_user(val, (int __user *) arg)) + break; + ps->flags = val; +- l2tp_info(session, PPPOL2TP_MSG_CONTROL, "%s: set flags=%d\n", ++ l2tp_info(session, L2TP_MSG_CONTROL, "%s: set flags=%d\n", + session->name, ps->flags); + err = 0; + break; +@@ -1100,7 +1150,7 @@ static int pppol2tp_session_ioctl(struct l2tp_session *session, + if (copy_to_user((void __user *) arg, &stats, + sizeof(stats))) + break; +- l2tp_info(session, PPPOL2TP_MSG_CONTROL, "%s: get L2TP stats\n", ++ l2tp_info(session, L2TP_MSG_CONTROL, "%s: get L2TP stats\n", + session->name); + err = 0; + break; +@@ -1128,7 +1178,7 @@ static int pppol2tp_tunnel_ioctl(struct l2tp_tunnel *tunnel, + struct sock *sk; + struct pppol2tp_ioc_stats stats; + +- l2tp_dbg(tunnel, PPPOL2TP_MSG_CONTROL, ++ l2tp_dbg(tunnel, L2TP_MSG_CONTROL, + "%s: pppol2tp_tunnel_ioctl(cmd=%#x, arg=%#lx)\n", + tunnel->name, cmd, arg); + +@@ -1171,7 +1221,7 @@ static int pppol2tp_tunnel_ioctl(struct l2tp_tunnel *tunnel, + err = -EFAULT; + break; + } +- l2tp_info(tunnel, PPPOL2TP_MSG_CONTROL, "%s: get L2TP stats\n", ++ l2tp_info(tunnel, L2TP_MSG_CONTROL, "%s: get L2TP stats\n", + tunnel->name); + err = 0; + break; +@@ -1261,7 +1311,7 @@ static int pppol2tp_tunnel_setsockopt(struct sock *sk, + switch (optname) { + case PPPOL2TP_SO_DEBUG: + tunnel->debug = val; +- l2tp_info(tunnel, PPPOL2TP_MSG_CONTROL, "%s: set debug=%x\n", ++ l2tp_info(tunnel, L2TP_MSG_CONTROL, "%s: set debug=%x\n", + tunnel->name, tunnel->debug); + break; + +@@ -1280,7 +1330,6 @@ static int pppol2tp_session_setsockopt(struct sock *sk, + int optname, int val) + { + int err = 0; +- struct pppol2tp_session *ps = l2tp_session_priv(session); + + switch (optname) { + case PPPOL2TP_SO_RECVSEQ: +@@ -1289,7 +1338,7 @@ static int pppol2tp_session_setsockopt(struct sock *sk, + break; + } + session->recv_seq = val ? -1 : 0; +- l2tp_info(session, PPPOL2TP_MSG_CONTROL, ++ l2tp_info(session, L2TP_MSG_CONTROL, + "%s: set recv_seq=%d\n", + session->name, session->recv_seq); + break; +@@ -1301,13 +1350,13 @@ static int pppol2tp_session_setsockopt(struct sock *sk, + } + session->send_seq = val ? -1 : 0; + { +- struct sock *ssk = ps->sock; +- struct pppox_sock *po = pppox_sk(ssk); ++ struct pppox_sock *po = pppox_sk(sk); ++ + po->chan.hdrlen = val ? PPPOL2TP_L2TP_HDR_SIZE_SEQ : + PPPOL2TP_L2TP_HDR_SIZE_NOSEQ; + } + l2tp_session_set_header_len(session, session->tunnel->version); +- l2tp_info(session, PPPOL2TP_MSG_CONTROL, ++ l2tp_info(session, L2TP_MSG_CONTROL, + "%s: set send_seq=%d\n", + session->name, session->send_seq); + break; +@@ -1318,20 +1367,20 @@ static int pppol2tp_session_setsockopt(struct sock *sk, + break; + } + session->lns_mode = val ? -1 : 0; +- l2tp_info(session, PPPOL2TP_MSG_CONTROL, ++ l2tp_info(session, L2TP_MSG_CONTROL, + "%s: set lns_mode=%d\n", + session->name, session->lns_mode); + break; + + case PPPOL2TP_SO_DEBUG: + session->debug = val; +- l2tp_info(session, PPPOL2TP_MSG_CONTROL, "%s: set debug=%x\n", ++ l2tp_info(session, L2TP_MSG_CONTROL, "%s: set debug=%x\n", + session->name, session->debug); + break; + + case PPPOL2TP_SO_REORDERTO: + session->reorder_timeout = msecs_to_jiffies(val); +- l2tp_info(session, PPPOL2TP_MSG_CONTROL, ++ l2tp_info(session, L2TP_MSG_CONTROL, + "%s: set reorder_timeout=%d\n", + session->name, session->reorder_timeout); + break; +@@ -1412,7 +1461,7 @@ static int pppol2tp_tunnel_getsockopt(struct sock *sk, + switch (optname) { + case PPPOL2TP_SO_DEBUG: + *val = tunnel->debug; +- l2tp_info(tunnel, PPPOL2TP_MSG_CONTROL, "%s: get debug=%x\n", ++ l2tp_info(tunnel, L2TP_MSG_CONTROL, "%s: get debug=%x\n", + tunnel->name, tunnel->debug); + break; + +@@ -1435,31 +1484,31 @@ static int pppol2tp_session_getsockopt(struct sock *sk, + switch (optname) { + case PPPOL2TP_SO_RECVSEQ: + *val = session->recv_seq; +- l2tp_info(session, PPPOL2TP_MSG_CONTROL, ++ l2tp_info(session, L2TP_MSG_CONTROL, + "%s: get recv_seq=%d\n", session->name, *val); + break; + + case PPPOL2TP_SO_SENDSEQ: + *val = session->send_seq; +- l2tp_info(session, PPPOL2TP_MSG_CONTROL, ++ l2tp_info(session, L2TP_MSG_CONTROL, + "%s: get send_seq=%d\n", session->name, *val); + break; + + case PPPOL2TP_SO_LNSMODE: + *val = session->lns_mode; +- l2tp_info(session, PPPOL2TP_MSG_CONTROL, ++ l2tp_info(session, L2TP_MSG_CONTROL, + "%s: get lns_mode=%d\n", session->name, *val); + break; + + case PPPOL2TP_SO_DEBUG: + *val = session->debug; +- l2tp_info(session, PPPOL2TP_MSG_CONTROL, "%s: get debug=%d\n", ++ l2tp_info(session, L2TP_MSG_CONTROL, "%s: get debug=%d\n", + session->name, *val); + break; + + case PPPOL2TP_SO_REORDERTO: + *val = (int) jiffies_to_msecs(session->reorder_timeout); +- l2tp_info(session, PPPOL2TP_MSG_CONTROL, ++ l2tp_info(session, L2TP_MSG_CONTROL, + "%s: get reorder_timeout=%d\n", session->name, *val); + break; + +@@ -1638,8 +1687,9 @@ static void pppol2tp_seq_session_show(struct seq_file *m, void *v) + { + struct l2tp_session *session = v; + struct l2tp_tunnel *tunnel = session->tunnel; +- struct pppol2tp_session *ps = l2tp_session_priv(session); +- struct pppox_sock *po = pppox_sk(ps->sock); ++ unsigned char state; ++ char user_data_ok; ++ struct sock *sk; + u32 ip = 0; + u16 port = 0; + +@@ -1649,6 +1699,15 @@ static void pppol2tp_seq_session_show(struct seq_file *m, void *v) + port = ntohs(inet->inet_sport); + } + ++ sk = pppol2tp_session_get_sock(session); ++ if (sk) { ++ state = sk->sk_state; ++ user_data_ok = (session == sk->sk_user_data) ? 'Y' : 'N'; ++ } else { ++ state = 0; ++ user_data_ok = 'N'; ++ } ++ + seq_printf(m, " SESSION '%s' %08X/%d %04X/%04X -> " + "%04X/%04X %d %c\n", + session->name, ip, port, +@@ -1656,9 +1715,7 @@ static void pppol2tp_seq_session_show(struct seq_file *m, void *v) + session->session_id, + tunnel->peer_tunnel_id, + session->peer_session_id, +- ps->sock->sk_state, +- (session == ps->sock->sk_user_data) ? +- 'Y' : 'N'); ++ state, user_data_ok); + seq_printf(m, " %d/%d/%c/%c/%s %08x %u\n", + session->mtu, session->mru, + session->recv_seq ? 'R' : '-', +@@ -1675,8 +1732,12 @@ static void pppol2tp_seq_session_show(struct seq_file *m, void *v) + atomic_long_read(&session->stats.rx_bytes), + atomic_long_read(&session->stats.rx_errors)); + +- if (po) ++ if (sk) { ++ struct pppox_sock *po = pppox_sk(sk); ++ + seq_printf(m, " interface %s\n", ppp_dev_name(&po->chan)); ++ sock_put(sk); ++ } + } + + static int pppol2tp_seq_show(struct seq_file *m, void *v) +diff --git a/net/socket.c b/net/socket.c +index 65afc8ec68d4..88abc72df2a6 100644 +--- a/net/socket.c ++++ b/net/socket.c +@@ -3321,3 +3321,49 @@ int kernel_sock_shutdown(struct socket *sock, enum sock_shutdown_cmd how) + return sock->ops->shutdown(sock, how); + } + EXPORT_SYMBOL(kernel_sock_shutdown); ++ ++/* This routine returns the IP overhead imposed by a socket i.e. ++ * the length of the underlying IP header, depending on whether ++ * this is an IPv4 or IPv6 socket and the length from IP options turned ++ * on at the socket. Assumes that the caller has a lock on the socket. ++ */ ++u32 kernel_sock_ip_overhead(struct sock *sk) ++{ ++ struct inet_sock *inet; ++ struct ip_options_rcu *opt; ++ u32 overhead = 0; ++ bool owned_by_user; ++#if IS_ENABLED(CONFIG_IPV6) ++ struct ipv6_pinfo *np; ++ struct ipv6_txoptions *optv6 = NULL; ++#endif /* IS_ENABLED(CONFIG_IPV6) */ ++ ++ if (!sk) ++ return overhead; ++ ++ owned_by_user = sock_owned_by_user(sk); ++ switch (sk->sk_family) { ++ case AF_INET: ++ inet = inet_sk(sk); ++ overhead += sizeof(struct iphdr); ++ opt = rcu_dereference_protected(inet->inet_opt, ++ owned_by_user); ++ if (opt) ++ overhead += opt->opt.optlen; ++ return overhead; ++#if IS_ENABLED(CONFIG_IPV6) ++ case AF_INET6: ++ np = inet6_sk(sk); ++ overhead += sizeof(struct ipv6hdr); ++ if (np) ++ optv6 = rcu_dereference_protected(np->opt, ++ owned_by_user); ++ if (optv6) ++ overhead += (optv6->opt_flen + optv6->opt_nflen); ++ return overhead; ++#endif /* IS_ENABLED(CONFIG_IPV6) */ ++ default: /* Returns 0 overhead if the socket is not ipv4 or ipv6 */ ++ return overhead; ++ } ++} ++EXPORT_SYMBOL(kernel_sock_ip_overhead); +diff --git a/scripts/gcc-plugins/Makefile b/scripts/gcc-plugins/Makefile +index 8b29dc17c73c..2cad963c4fb7 100644 +--- a/scripts/gcc-plugins/Makefile ++++ b/scripts/gcc-plugins/Makefile +@@ -9,6 +9,7 @@ else + HOST_EXTRACXXFLAGS += -I$(GCC_PLUGINS_DIR)/include -I$(src) -std=gnu++98 -fno-rtti + HOST_EXTRACXXFLAGS += -fno-exceptions -fasynchronous-unwind-tables -ggdb + HOST_EXTRACXXFLAGS += -Wno-narrowing -Wno-unused-variable ++ HOST_EXTRACXXFLAGS += -Wno-format-diag + export HOST_EXTRACXXFLAGS + endif + +diff --git a/scripts/gcc-plugins/gcc-common.h b/scripts/gcc-plugins/gcc-common.h +index 08fe09c28bd2..6792915f5174 100644 +--- a/scripts/gcc-plugins/gcc-common.h ++++ b/scripts/gcc-plugins/gcc-common.h +@@ -31,7 +31,9 @@ + #include "ggc.h" + #include "timevar.h" + ++#if BUILDING_GCC_VERSION < 10000 + #include "params.h" ++#endif + + #if BUILDING_GCC_VERSION <= 4009 + #include "pointer-set.h" +@@ -796,6 +798,7 @@ static inline gimple gimple_build_assign_with_ops(enum tree_code subcode, tree l + return gimple_build_assign(lhs, subcode, op1, op2 PASS_MEM_STAT); + } + ++#if BUILDING_GCC_VERSION < 10000 + template <> + template <> + inline bool is_a_helper<const ggoto *>::test(const_gimple gs) +@@ -809,6 +812,7 @@ inline bool is_a_helper<const greturn *>::test(const_gimple gs) + { + return gs->code == GIMPLE_RETURN; + } ++#endif + + static inline gasm *as_a_gasm(gimple stmt) + { +diff --git a/security/integrity/evm/evm_crypto.c b/security/integrity/evm/evm_crypto.c +index c783fefa558a..e034dc21421e 100644 +--- a/security/integrity/evm/evm_crypto.c ++++ b/security/integrity/evm/evm_crypto.c +@@ -90,7 +90,7 @@ static struct shash_desc *init_desc(char type) + algo = evm_hash; + } + +- if (*tfm == NULL) { ++ if (IS_ERR_OR_NULL(*tfm)) { + mutex_lock(&mutex); + if (*tfm) + goto out; +diff --git a/security/integrity/ima/ima_fs.c b/security/integrity/ima/ima_fs.c +index 44b44d7e0dbc..853a7d2333b3 100644 +--- a/security/integrity/ima/ima_fs.c ++++ b/security/integrity/ima/ima_fs.c +@@ -331,8 +331,7 @@ static ssize_t ima_write_policy(struct file *file, const char __user *buf, + integrity_audit_msg(AUDIT_INTEGRITY_STATUS, NULL, NULL, + "policy_update", "signed policy required", + 1, 0); +- if (ima_appraise & IMA_APPRAISE_ENFORCE) +- result = -EACCES; ++ result = -EACCES; + } else { + result = ima_parse_add_rule(data); + } +diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c +index f09ae7efc695..f0052c06d065 100644 +--- a/sound/core/pcm_lib.c ++++ b/sound/core/pcm_lib.c +@@ -456,6 +456,7 @@ static int snd_pcm_update_hw_ptr0(struct snd_pcm_substream *substream, + + no_delta_check: + if (runtime->status->hw_ptr == new_hw_ptr) { ++ runtime->hw_ptr_jiffies = curr_jiffies; + update_audio_tstamp(substream, &curr_tstamp, &audio_tstamp); + return 0; + } |