diff options
| author |   Markus Armbruster <armbru@redhat.com> | 2009-10-07 01:16:01 +0200 |
|---|---|---|
| committer |   Anthony Liguori <aliguori@us.ibm.com> | 2009-10-07 08:54:55 -0500 |
| commit | 5c17ca2505197c56d0097c66a4e5bda4d6f32fb6 (patch) | |
| tree | 011adae1a2f9ce724c92629bd99b78507a7d97ec /hw/parallel.c | |
| parent | Warn if value of qdev_init() isn't checked (diff) | |
| download | qemu-kvm-5c17ca2505197c56d0097c66a4e5bda4d6f32fb6.tar.gz qemu-kvm-5c17ca2505197c56d0097c66a4e5bda4d6f32fb6.tar.bz2 qemu-kvm-5c17ca2505197c56d0097c66a4e5bda4d6f32fb6.zip | |
Clean up test for qdev_init() failure
Some callers test for != 0, some for < 0. Normalize to < 0.
Patchworks-ID: 35171
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'hw/parallel.c')
| -rw-r--r-- | hw/parallel.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/parallel.c b/hw/parallel.c index 2635edcaf..92eecb152 100644 --- a/hw/parallel.c +++ b/hw/parallel.c @@ -493,7 +493,7 @@ ParallelState *parallel_init(int index, CharDriverState *chr) qdev_prop_set_uint32(&dev->qdev, "iobase", isa_parallel_io[index]); qdev_prop_set_uint32(&dev->qdev, "irq", 7); qdev_prop_set_chr(&dev->qdev, "chardev", chr); - if (qdev_init(&dev->qdev) != 0) + if (qdev_init(&dev->qdev) < 0) return NULL; return &DO_UPCAST(ISAParallelState, dev, dev)->state; } |