diff options
| author |   Gerd Hoffmann <kraxel@redhat.com> | 2009-07-15 13:43:31 +0200 |
|---|---|---|
| committer |   Anthony Liguori <aliguori@us.ibm.com> | 2009-07-16 17:28:51 -0500 |
| commit | ee6847d19be16c789b8bd4e553b7cd6701ba1245 (patch) | |
| tree | 41845b3b1e8740ce97daf0582e124c6b6e0a6873 /hw/syborg.c | |
| parent | monitor: Add port write command (diff) | |
| download | qemu-kvm-ee6847d19be16c789b8bd4e553b7cd6701ba1245.tar.gz qemu-kvm-ee6847d19be16c789b8bd4e553b7cd6701ba1245.tar.bz2 qemu-kvm-ee6847d19be16c789b8bd4e553b7cd6701ba1245.zip | |
qdev: rework device properties.
This patch is a major overhaul of the device properties. The properties
are saved directly in the device state struct now, the linked list of
property values is gone.
Advantages:
* We don't have to maintain the list with the property values.
* The value in the property list and the value actually used by
the device can't go out of sync any more (used to happen for
the pci.devfn == -1 case) because there is only one place where
the value is stored.
* A record describing the property is required now, you can't set
random properties any more.
There are bus-specific and device-specific properties. The former
should be used for properties common to all bus drivers. Typical
use case is bus addressing, i.e. pci.devfn and i2c.address.
Properties have a PropertyInfo struct attached with name, size and
function pointers to parse and print properties. A few common property
types have PropertyInfos defined in qdev-properties.c. Drivers are free
to implement their own very special property parsers if needed.
Properties can have default values. If unset they are zero-filled.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'hw/syborg.c')
| -rw-r--r-- | hw/syborg.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/hw/syborg.c b/hw/syborg.c index 5ca9977b2..d8d38d48e 100644 --- a/hw/syborg.c +++ b/hw/syborg.c @@ -64,7 +64,7 @@ static void syborg_init(ram_addr_t ram_size, sysbus_create_simple("syborg,rtc", 0xC0001000, NULL); dev = qdev_create(NULL, "syborg,timer"); - qdev_set_prop_int(dev, "frequency", 1000000); + qdev_prop_set_uint32(dev, "frequency", 1000000); qdev_init(dev); sysbus_mmio_map(sysbus_from_qdev(dev), 0, 0xC0002000); sysbus_connect_irq(sysbus_from_qdev(dev), 0, pic[1]); @@ -83,7 +83,7 @@ static void syborg_init(ram_addr_t ram_size, qemu_check_nic_model(&nd_table[0], "virtio"); dev = qdev_create(NULL, "syborg,virtio-net"); - qdev_set_netdev(dev, &nd_table[0]); + dev->nd = &nd_table[0]; qdev_init(dev); s = sysbus_from_qdev(dev); sysbus_mmio_map(s, 0, 0xc000c000); |