diff options
author | Tom de Vries <tdevries@suse.de> | 2019-05-21 16:32:41 +0200 |
---|---|---|
committer | Tom de Vries <tdevries@suse.de> | 2019-05-21 16:32:41 +0200 |
commit | fb7806c7a49d6eb75cdbff183d10d00f75968c0f (patch) | |
tree | 60137fcb017373136def38a45563664f544ca283 /gdb/cli | |
parent | [gdb/testsuite] Require c++11 where necessary (diff) | |
download | binutils-gdb-fb7806c7a49d6eb75cdbff183d10d00f75968c0f.tar.gz binutils-gdb-fb7806c7a49d6eb75cdbff183d10d00f75968c0f.tar.bz2 binutils-gdb-fb7806c7a49d6eb75cdbff183d10d00f75968c0f.zip |
[gdb/cli] Fix use of uninitialized variable in complete_command
When building gdb on ubuntu 16.04 with gcc 5.4.0, and running the gdb
testsuite we run into:
...
FAIL: gdb.linespec/explicit.exp: complete after -line: \
cmd complete "b -line argument " (timeout)
...
The failure is reproducible outside the testsuite like this:
...
$ gdb -q build/gdb/testsuite/outputs/gdb.linespec/explicit/explicit \
-ex "complete b -line argument"
Reading symbols from \
build/gdb/testsuite/outputs/gdb.linespec/explicit/explicit...
terminate called after throwing an instance of 'std::length_error'
what(): basic_string::_M_create
Aborted (core dumped)
...
The problem is here in complete_command:
...
completion_result result = complete (arg, &word, "e_char);
std::string arg_prefix (arg, word - arg);
if (result.number_matches != 0)
...
The problem is that the word variable is not initialized when
result.number_matches == 0, but the variable is still used in the arg_prefix
initialization.
Fix this by guarding the arg_prefix initialization with the
'result.number_matches != 0' test.
Build and tested on x86_64-linux.
gdb/ChangeLog:
2019-05-21 Tom de Vries <tdevries@suse.de>
PR cli/24587
* cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
Diffstat (limited to 'gdb/cli')
-rw-r--r-- | gdb/cli/cli-cmds.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c index 332078b910f..daf409a5580 100644 --- a/gdb/cli/cli-cmds.c +++ b/gdb/cli/cli-cmds.c @@ -248,10 +248,10 @@ complete_command (const char *arg, int from_tty) completion_result result = complete (arg, &word, "e_char); - std::string arg_prefix (arg, word - arg); - if (result.number_matches != 0) { + std::string arg_prefix (arg, word - arg); + if (result.number_matches == 1) printf_unfiltered ("%s%s\n", arg_prefix.c_str (), result.match_list[0]); else |