aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJames Hogan <james.hogan@imgtec.com>2014-09-01 22:48:40 +0100
committerMaciej W. Rozycki <macro@codesourcery.com>2014-09-03 22:09:10 +0100
commitac740bc7a9103a561329ebf7aa05ff31bcab2267 (patch)
tree6b3243a23c0c7bddbfcfdbe9eeaa11ee97798f67 /gdb/mips-linux-nat.c
parentPR python/16699: GDB Python command completion with overriden complete vs. co... (diff)
downloadbinutils-gdb-ac740bc7a9103a561329ebf7aa05ff31bcab2267.tar.gz
binutils-gdb-ac740bc7a9103a561329ebf7aa05ff31bcab2267.tar.bz2
binutils-gdb-ac740bc7a9103a561329ebf7aa05ff31bcab2267.zip
Reset errno before PTRACE_PEEKUSER for MIPS DSP_CONTROL
PTRACE_PEEKUSER can return -1, which is usually used to determine whether a system call has reported an error, so errno must be used alone to determine whether an error occurred. However errno isn't modified by a successful system call so it must be reset to a known value (0) before the syscall call. Add the missing errno reset when reading the DSP_CONTROL register in the native MIPS Linux backend and the MIPS gdbserver backend. gdb/: * mips-linux-nat.c (mips_linux_read_description): Reset errno to 0 prior to reading DSP_CONTROL with PTRACE_PEEKUSER ptrace call. gdb/gdbserver/: * linux-mips-low.c (mips_read_description): Reset errno to 0 prior to reading DSP_CONTROL with PTRACE_PEEKUSER ptrace call.
Diffstat (limited to 'gdb/mips-linux-nat.c')
-rw-r--r--gdb/mips-linux-nat.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/gdb/mips-linux-nat.c b/gdb/mips-linux-nat.c
index 88faa1edf69..ffc8411ca3b 100644
--- a/gdb/mips-linux-nat.c
+++ b/gdb/mips-linux-nat.c
@@ -439,6 +439,7 @@ mips_linux_read_description (struct target_ops *ops)
if (tid == 0)
tid = ptid_get_pid (inferior_ptid);
+ errno = 0;
ptrace (PTRACE_PEEKUSER, tid, DSP_CONTROL, 0);
switch (errno)
{