diff options
author | Marcin Kościelnicki <koriakin@0x04.net> | 2015-11-02 20:27:19 +0100 |
---|---|---|
committer | Marcin Kościelnicki <koriakin@0x04.net> | 2015-11-03 11:56:18 +0100 |
commit | 7ad8b86c674ed941b354322f608cd964ca0affb2 (patch) | |
tree | 2e9633225d7d2e312a6588e0b303c0b6def7874c /gdb/testsuite/gdb.reverse | |
parent | Add myself to gdb MAINTAINERS (diff) | |
download | binutils-gdb-7ad8b86c674ed941b354322f608cd964ca0affb2.tar.gz binutils-gdb-7ad8b86c674ed941b354322f608cd964ca0affb2.tar.bz2 binutils-gdb-7ad8b86c674ed941b354322f608cd964ca0affb2.zip |
gdb/reverse: Fix continue_to_breakpoint in syscall testcases.
continue_to_breakpoint always continues to the next breakpoint, not to the
one named in parameter. This rendered the tests effectively useless, since
marker2 was never reached.
gdb/testsuite/ChangeLog:
* gdb.reverse/fstatat-reverse.exp: Set breakpoint on marker1 after
reaching marker2.
* gdb.reverse/getresuid-reverse.exp: Likewise.
* gdb.reverse/pipe-reverse.exp: Likewise.
* gdb.reverse/readv-reverse.exp: Likewise.
* gdb.reverse/recvmsg-reverse.exp: Likewise.
* gdb.reverse/time-reverse.exp: Likewise.
* gdb.reverse/waitpid-reverse.exp: Likewise and add KFAILs.
Diffstat (limited to 'gdb/testsuite/gdb.reverse')
-rw-r--r-- | gdb/testsuite/gdb.reverse/fstatat-reverse.exp | 8 | ||||
-rw-r--r-- | gdb/testsuite/gdb.reverse/getresuid-reverse.exp | 8 | ||||
-rw-r--r-- | gdb/testsuite/gdb.reverse/pipe-reverse.exp | 8 | ||||
-rw-r--r-- | gdb/testsuite/gdb.reverse/readv-reverse.exp | 8 | ||||
-rw-r--r-- | gdb/testsuite/gdb.reverse/recvmsg-reverse.exp | 8 | ||||
-rw-r--r-- | gdb/testsuite/gdb.reverse/time-reverse.exp | 8 | ||||
-rw-r--r-- | gdb/testsuite/gdb.reverse/waitpid-reverse.exp | 10 |
7 files changed, 30 insertions, 28 deletions
diff --git a/gdb/testsuite/gdb.reverse/fstatat-reverse.exp b/gdb/testsuite/gdb.reverse/fstatat-reverse.exp index 09deb6cb655..e9b2ca82f2f 100644 --- a/gdb/testsuite/gdb.reverse/fstatat-reverse.exp +++ b/gdb/testsuite/gdb.reverse/fstatat-reverse.exp @@ -36,16 +36,16 @@ if [supports_process_record] { gdb_test_no_output "record" "Turn on process record" } -gdb_test "break marker1" \ - "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ - "set breakpoint at marker1" - gdb_test "break marker2" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker2" gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" +gdb_test "break marker1" \ + "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ + "set breakpoint at marker1" + gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1" # If the variable was recorded properly on syscall, the old contents (0) diff --git a/gdb/testsuite/gdb.reverse/getresuid-reverse.exp b/gdb/testsuite/gdb.reverse/getresuid-reverse.exp index b93fb913107..a625113ef3a 100644 --- a/gdb/testsuite/gdb.reverse/getresuid-reverse.exp +++ b/gdb/testsuite/gdb.reverse/getresuid-reverse.exp @@ -36,16 +36,16 @@ if [supports_process_record] { gdb_test_no_output "record" "Turn on process record" } -gdb_test "break marker1" \ - "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ - "set breakpoint at marker1" - gdb_test "break marker2" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker2" gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" +gdb_test "break marker1" \ + "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ + "set breakpoint at marker1" + gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1" # If the variables were recorded properly on syscall, the old contents (-1) diff --git a/gdb/testsuite/gdb.reverse/pipe-reverse.exp b/gdb/testsuite/gdb.reverse/pipe-reverse.exp index 482893a2343..5d5048823ac 100644 --- a/gdb/testsuite/gdb.reverse/pipe-reverse.exp +++ b/gdb/testsuite/gdb.reverse/pipe-reverse.exp @@ -36,16 +36,16 @@ if [supports_process_record] { gdb_test_no_output "record" "Turn on process record" } -gdb_test "break marker1" \ - "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ - "set breakpoint at marker1" - gdb_test "break marker2" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker2" gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" +gdb_test "break marker1" \ + "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ + "set breakpoint at marker1" + gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1" # If the variables were recorded properly on syscall, the old contents (-1) diff --git a/gdb/testsuite/gdb.reverse/readv-reverse.exp b/gdb/testsuite/gdb.reverse/readv-reverse.exp index 4158c10671a..c9178d92ec1 100644 --- a/gdb/testsuite/gdb.reverse/readv-reverse.exp +++ b/gdb/testsuite/gdb.reverse/readv-reverse.exp @@ -36,16 +36,16 @@ if [supports_process_record] { gdb_test_no_output "record" "Turn on process record" } -gdb_test "break marker1" \ - "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ - "set breakpoint at marker1" - gdb_test "break marker2" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker2" gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" +gdb_test "break marker1" \ + "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ + "set breakpoint at marker1" + gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1" # If the variables were recorded properly on syscall, the old contents ("") diff --git a/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp b/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp index 7293a3d5184..2540b91bc36 100644 --- a/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp +++ b/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp @@ -36,16 +36,16 @@ if [supports_process_record] { gdb_test_no_output "record" "Turn on process record" } -gdb_test "break marker1" \ - "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ - "set breakpoint at marker1" - gdb_test "break marker2" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker2" gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" +gdb_test "break marker1" \ + "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ + "set breakpoint at marker1" + gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1" # If the variables were recorded properly on syscall, the old contents will diff --git a/gdb/testsuite/gdb.reverse/time-reverse.exp b/gdb/testsuite/gdb.reverse/time-reverse.exp index 9cec3c37e7f..1cc111b746b 100644 --- a/gdb/testsuite/gdb.reverse/time-reverse.exp +++ b/gdb/testsuite/gdb.reverse/time-reverse.exp @@ -36,16 +36,16 @@ if [supports_process_record] { gdb_test_no_output "record" "Turn on process record" } -gdb_test "break marker1" \ - "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ - "set breakpoint at marker1" - gdb_test "break marker2" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker2" gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" +gdb_test "break marker1" \ + "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ + "set breakpoint at marker1" + gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1" # If the variable was recorded properly on syscall, the old contents (-1) diff --git a/gdb/testsuite/gdb.reverse/waitpid-reverse.exp b/gdb/testsuite/gdb.reverse/waitpid-reverse.exp index f4a440365df..ddd8d7b80cf 100644 --- a/gdb/testsuite/gdb.reverse/waitpid-reverse.exp +++ b/gdb/testsuite/gdb.reverse/waitpid-reverse.exp @@ -36,16 +36,18 @@ if [supports_process_record] { gdb_test_no_output "record" "Turn on process record" } -gdb_test "break marker1" \ - "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ - "set breakpoint at marker1" - gdb_test "break marker2" \ "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ "set breakpoint at marker2" +setup_kfail "gdb/19187" *-*-* gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*" +gdb_test "break marker1" \ + "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ + "set breakpoint at marker1" + +setup_kfail "gdb/19187" *-*-* gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1" # If the variable was recorded properly on syscall, the old contents (-1) |