diff options
| author |   Cary Coutant <ccoutant@gmail.com> | 2016-01-11 23:57:44 -0800 |
|---|---|---|
| committer | Cary Coutant <ccoutant@gmail.com> | 2016-01-11 23:58:28 -0800 |
| commit | d21f123b0ead1806416cf0dafae12bec4cca8920 (patch) | |
| tree | e7bb3b97fd199b76de698f77e923cda8bb5ba29c /gold/i386.cc | |
| parent | sim: mips: workaround 32-bit addr sign extensions (diff) | |
| download | binutils-gdb-d21f123b0ead1806416cf0dafae12bec4cca8920.tar.gz binutils-gdb-d21f123b0ead1806416cf0dafae12bec4cca8920.tar.bz2 binutils-gdb-d21f123b0ead1806416cf0dafae12bec4cca8920.zip | |
Fix internal error when applying TLSDESC relocations with no TLS segment.
gold/
PR gold/19353
* aarch64.cc (Target_aarch64::relocate_tls): Don't insist that
we have a TLS segment for GD-to-IE optimization.
* i386.cc (Target_i386::tls_gd_to_ie): Remove tls_segment parameter.
Adjust all calls.
(Target_i386::tls_desc_gd_to_ie): Likewise.
(Target_i386::relocate_tls): Don't insist that we have a TLS segment
for TLSDESC GD-to-IE optimizations.
* x86_64.cc (Target_x86_64::tls_gd_to_ie): Remove tls_segment parameter.
Adjust all calls.
(Target_x86_64::tls_desc_gd_to_ie): Likewise.
(Target_x86_64::relocate_tls): Don't insist that we have a TLS segment
for TLSDESC GD-to-IE optimizations.
Diffstat (limited to 'gold/i386.cc')
| -rw-r--r-- | gold/i386.cc | 14 |
1 files changed, 2 insertions, 12 deletions
diff --git a/gold/i386.cc b/gold/i386.cc index 82886d4b8a9..a7168a8f1f4 100644 --- a/gold/i386.cc +++ b/gold/i386.cc @@ -668,7 +668,6 @@ class Target_i386 : public Sized_target<32, false> // Do a TLS General-Dynamic to Initial-Exec transition. inline void tls_gd_to_ie(const Relocate_info<32, false>*, size_t relnum, - Output_segment* tls_segment, const elfcpp::Rel<32, false>&, unsigned int r_type, elfcpp::Elf_types<32>::Elf_Addr value, unsigned char* view, @@ -687,7 +686,6 @@ class Target_i386 : public Sized_target<32, false> // transition. inline void tls_desc_gd_to_ie(const Relocate_info<32, false>*, size_t relnum, - Output_segment* tls_segment, const elfcpp::Rel<32, false>&, unsigned int r_type, elfcpp::Elf_types<32>::Elf_Addr value, unsigned char* view, @@ -3054,7 +3052,7 @@ Target_i386::Relocate::relocate_tls(const Relocate_info<32, false>* relinfo, } if (optimized_type == tls::TLSOPT_TO_IE) { - this->tls_gd_to_ie(relinfo, relnum, tls_segment, rel, r_type, + this->tls_gd_to_ie(relinfo, relnum, rel, r_type, got_offset, view, view_size); break; } @@ -3116,13 +3114,7 @@ Target_i386::Relocate::relocate_tls(const Relocate_info<32, false>* relinfo, } if (optimized_type == tls::TLSOPT_TO_IE) { - if (tls_segment == NULL) - { - gold_assert(parameters->errors()->error_count() > 0 - || issue_undefined_symbol_error(gsym)); - return; - } - this->tls_desc_gd_to_ie(relinfo, relnum, tls_segment, rel, r_type, + this->tls_desc_gd_to_ie(relinfo, relnum, rel, r_type, got_offset, view, view_size); break; } @@ -3354,7 +3346,6 @@ Target_i386::Relocate::tls_gd_to_le(const Relocate_info<32, false>* relinfo, inline void Target_i386::Relocate::tls_gd_to_ie(const Relocate_info<32, false>* relinfo, size_t relnum, - Output_segment*, const elfcpp::Rel<32, false>& rel, unsigned int, elfcpp::Elf_types<32>::Elf_Addr value, @@ -3449,7 +3440,6 @@ inline void Target_i386::Relocate::tls_desc_gd_to_ie( const Relocate_info<32, false>* relinfo, size_t relnum, - Output_segment*, const elfcpp::Rel<32, false>& rel, unsigned int r_type, elfcpp::Elf_types<32>::Elf_Addr value, |