aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Ruppert <idl0r@gentoo.org>2014-08-23 23:03:22 +0200
committerChristian Ruppert <idl0r@gentoo.org>2014-08-23 23:03:22 +0200
commit6fbac3dcf0a3f54e1901bb4cc2977252c809e46b (patch)
treea837247e5d84838a2fc3b9131219ddd29ef3c7aa
parentAll calls to git-config need to be wrapped by the umask handler. (diff)
downloadgitolite-gentoo-master-g2.tar.gz
gitolite-gentoo-master-g2.tar.bz2
gitolite-gentoo-master-g2.zip
Fix setting umask in setup_gitweb_access() and refactoringgitolite-gentoo-2.3.3master-g2
Signed-off-by: Christian Ruppert <idl0r@gentoo.org>
-rw-r--r--src/gitolite.pm7
1 files changed, 2 insertions, 5 deletions
diff --git a/src/gitolite.pm b/src/gitolite.pm
index 9162ac9..e63bd93 100644
--- a/src/gitolite.pm
+++ b/src/gitolite.pm
@@ -489,9 +489,7 @@ sub setup_git_configs
# git_configs_p is a ref to a hash whose elements look like
# {"reponame"}{sequence_number}{"key"} = "value";
- my $oldumask = umask();
- my $newumask = get_repo_umask($repo);
- umask($newumask);
+ my $oldumask = umask(get_repo_umask($repo));
my %rch = %{ $git_configs_p->{$repo} };
# %rch has elements that look like {sequence_number}{"key"} = "value"
@@ -580,8 +578,7 @@ sub setup_gitweb_access
# we may override but we do not remove gitweb.owner and description
# for wild repos
- my $newumask = get_repo_umask($repo);
- my $oldumask = umask();
+ my $oldumask = umask(get_repo_umask($repo));
if ($desc) {
open(DESC, ">", $desc_file);