diff options
| author |   Kemi Wang <kemi.wang@intel.com> | 2018-12-01 07:03:33 -0800 |
|---|---|---|
| committer |   H.J. Lu <hjl.tools@gmail.com> | 2018-12-01 08:19:20 -0800 |
| commit | 6310e6be9b7c322d56a45729b3ebcd22e26dd0c2 (patch) | |
| tree | 577b9815c0ab096a7d120ddf8ae7ca44ea166c1b /nptl/pthreadP.h | |
| parent | stdlib: assert on NULL function pointer in atexit etc. [BZ #20544] (diff) | |
| download | glibc-6310e6be9b7c322d56a45729b3ebcd22e26dd0c2.tar.gz glibc-6310e6be9b7c322d56a45729b3ebcd22e26dd0c2.tar.bz2 glibc-6310e6be9b7c322d56a45729b3ebcd22e26dd0c2.zip | |
Mutex: Add pthread mutex tunables
This patch does not have any functionality change, we only provide a spin
count tunes for pthread adaptive spin mutex. The tunable
glibc.pthread.mutex_spin_count tunes can be used by system administrator to
squeeze system performance according to different hardware capabilities and
workload characteristics.
The maximum value of spin count is limited to 32767 to avoid the overflow
of mutex->__data.__spins variable with the possible type of short in
pthread_mutex_lock ().
The default value of spin count is set to 100 with the reference to the
previous number of times of spinning via trylock. This value would be
architecture-specific and can be tuned with kinds of benchmarks to fit most
cases in future.
I would extend my appreciation sincerely to H.J.Lu for his help to refine
this patch series.
* manual/tunables.texi (POSIX Thread Tunables): New node.
* nptl/Makefile (libpthread-routines): Add pthread_mutex_conf.
* nptl/nptl-init.c: Include pthread_mutex_conf.h
(__pthread_initialize_minimal_internal) [HAVE_TUNABLES]: Call
__pthread_tunables_init.
* nptl/pthreadP.h (MAX_ADAPTIVE_COUNT): Remove.
(max_adaptive_count): Define.
* nptl/pthread_mutex_conf.c: New file.
* nptl/pthread_mutex_conf.h: New file.
* sysdeps/generic/adaptive_spin_count.h: New file.
* sysdeps/nptl/dl-tunables.list: New file.
* nptl/pthread_mutex_lock.c (__pthread_mutex_lock): Use
max_adaptive_count () not MAX_ADAPTIVE_COUNT.
* nptl/pthread_mutex_timedlock.c (__pthrad_mutex_timedlock):
Likewise.
Suggested-by: Andi Kleen <andi.kleen@intel.com>
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Signed-off-by: Kemi.wang <kemi.wang@intel.com>
Diffstat (limited to 'nptl/pthreadP.h')
| -rw-r--r-- | nptl/pthreadP.h | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/nptl/pthreadP.h b/nptl/pthreadP.h index 19efe1e35f..7f16ba9800 100644 --- a/nptl/pthreadP.h +++ b/nptl/pthreadP.h @@ -33,6 +33,7 @@ #include <kernel-features.h> #include <errno.h> #include <internal-signals.h> +#include "pthread_mutex_conf.h" /* Atomic operations on TLS memory. */ @@ -47,10 +48,14 @@ #endif -/* Adaptive mutex definitions. */ -#ifndef MAX_ADAPTIVE_COUNT -# define MAX_ADAPTIVE_COUNT 100 +static inline short max_adaptive_count (void) +{ +#if HAVE_TUNABLES + return __mutex_aconf.spin_count; +#else + return DEFAULT_ADAPTIVE_COUNT; #endif +} /* Magic cookie representing robust mutex with dead owner. */ |