| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
|
|
| |
Once again they broke the API, this time around the .captures() call.
They changed it by a lot, returning a dict of capture names to captures.
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
| |
Resolves: https://github.com/pkgcore/pkgcheck/issues/695
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
| |
Resolves: https://github.com/pkgcore/pkgcheck/issues/693
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
| |
Resolves: https://github.com/pkgcore/pkgcheck/issues/659
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
|
| |
This handles spaces and such much much better
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
|
|
|
| |
Now that most ebuilds use PEP-517 mode, we can relax the check a little
to handle cases where the variable is set in the eclass (for example
tree-sitter based ebuilds).
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
|
| |
Fixes: 4a7a02f60c9f87ad85670e0e798c5aadb8096c92
Resolves: https://github.com/pkgcore/pkgcheck/issues/679
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
|
|
|
|
| |
It might sometimes not find any intersection of eclasses EAPIs, in which
it is better to not report anything then to report a false positive or
worse, to explode with exception.
Resolves: https://github.com/pkgcore/pkgcheck/issues/679
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
|
|
|
| |
followup to f691ea197c3db922edf33e570708751421db48aa
Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
Closes: https://github.com/pkgcore/pkgcheck/pull/678
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
e.g.
pkgcheck scan --net -c HomepageUrlCheck --timeout 0 app-admin/chrootuid
at checkout 127160ac611d39cc6bb2ca21fcf99a086fe2b176
Python's ftplib raises a ValueError with timeout=0. Use timeout=None to
put the underlying socket in blocking mode. See
https://docs.python.org/3/library/socket.html#socket.socket.settimeout
for legal timeout values.
Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
|
|
|
|
| |
ArgumentParser added a separator to its option tuple with
>=python-3.11.9, which snakeoil-0.10.7 does not handle correctly.
https://github.com/python/cpython/pull/114180
Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
|
|
|
|
|
| |
Since we don't need to build tree-sitter-bash lib, we became pure python
package, where flit is much better suited for this task. This now also
matches other packages under pkgcore stack. This simplifies a lot the
release process, as we don't need to build the lib anymore using
cibuildwheel.
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
|
|
| |
We can use the new tree-sitter-bash python package, which has the
library, so we can simplify the build a lot.
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
|
| |
Resolves: https://github.com/pkgcore/pkgcheck/issues/671
Resolves: https://github.com/pkgcore/pkgcheck/issues/672
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
|
|
|
| |
Catch cases where new ebuilds are committed with old EAPIs. This is
checked during `--commits` stage.
Resolves: https://github.com/pkgcore/pkgcheck/issues/666
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
| |
Resolves: https://github.com/pkgcore/pkgcheck/issues/668
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 9cb39d40ef6334961bc247edc722d893abce9985.
Temproarily disable Python 3.13 in CI as lxml isn't building anymore, even
though it did until about last week...
Signed-off-by: Sam James <sam@gentoo.org>
Closes: https://github.com/pkgcore/pkgcheck/pull/665
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 9103513e26f9f2aeade5b563a49697c0e2665e3e.
I originally added --no-find-copies in e688357bdc5773009bb2e106075d9852f2513f89
to suppress git being too clever which ends up confusing our git integration, as
we're not really interested in copies. I was going to use --no-find-copies-harder
but I figured --no-find-copies sounded better as it was less specific and for
our purposes here, we don't want copies at all, so why not?
But --no-find-copies isn't a boolean option, it's just that until git commit
5825268db1058516d05be03d6a8d8d55eea5a943 ('parse-options: fully disable option abbreviation with PARSE_OPT_KEEP_UNKNOWN'),
it tolerated it and expanded it to --no-find-copies-harder. Oops!
Let's use --no-find-copies-harder as we originally should have, as the only
available option to control the behavior, modulo setting a similarity % threshold
with --find-copies=n.
We're fine to do this as, quoting the git-log docs:
"[...] and options applicable to the git-diff[1] command to control how the changes each commit introduces are shown."
Bug: https://bugs.gentoo.org/924718
Bug: https://github.com/pkgcore/pkgcheck/issues/663
Signed-off-by: Sam James <sam@gentoo.org>
Closes: https://github.com/pkgcore/pkgcheck/pull/664
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
|
|
|
|
| |
It broke with git-2.43.2, until further upstream work by Sam James, I'll
just revert it.
Bug: https://bugs.gentoo.org/924718
Reverts: e688357bdc5773009bb2e106075d9852f2513f89
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
|
|
|
|
| |
Most notably, this includes NotOpenSSLWarning:
https://github.com/urllib3/urllib3/issues/3020#issuecomment-1785873825
Signed-off-by: Anna “CyberTailor” <cyber@sysrq.in>
Closes: https://github.com/pkgcore/pkgcheck/pull/661
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gentoo developers are rejecting routine version bumps for ebuild
variables being defined in a different order than skel.ebuild.
This new lint ensures pkgcheck identifies these problems before
we waste developer time.
Regarding tests, in spite of the massive diff, all that's been done
is re-ordering the variables to avoid introducing new style warnings
into existing tests.
Signed-off-by: Anthony Ryan <anthonyryan1@gmail.com>
Closes: https://github.com/pkgcore/pkgcheck/pull/645
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
|
|
|
|
| |
For any references that go back into those, they're not
reachable for doc rendering without this.
Signed-off-by: Brian Harring <ferringb@gmail.com>
Closes: https://github.com/pkgcore/pkgcheck/pull/658
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is based on mixture of my knowledge and the invocation below.
Current *approximate* authorship based on git deltas (ignoring testdata since
it's not usually in LOC and tree-sitter-bash since it's a vendored import)
```
ferringb@frith ~/gentoo/pkgcheck $ git ls-files | grep -v testdata/ | grep -v tree-sitter-bash/ | xargs -n1 git blame -ew | cut -d\< -f2 | cut -d\> -f1 | cut -d\@ -f1 | sort -g | uniq -c | sort -gr
17265 radhermit
10391 arthurzam
1410 mgorny
933 ferringb
199 marienz
```
Note things like tweaking a line to use a genexp (py>=2.4) rather than
listcomp (py>=2.3) obscures ownership and doesn't actually override original
ownership.
mgorny is added for obvious reasons- copyright + activity.
Myself and Marienz are in there since pre 2013 I wrote... a lot.. (~66% loc, all functionality),
and Marien wrote a lot of checks + tests prior to dropping off in 2006 (~33% loc even as of 2013).
It's not obvious without looking through annotations and having some historical knowledge,
but fundamental bits and fundamental addons (UseAddon for example) were his and are still *there*
even if minor code tweaks obscure it. Minimally they should be in this list based on the
significance and importance of contribution alone.
Signed-off-by: Brian Harring <ferringb@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The point here is to be able to look back through time on the evolution to
understand what/why things changed. In particular, it's useful to trace
back and get a sense of the age of the code and use that as a gauge for the
potential that things changed w/out it being updated, or was working around
things from py2.4 era.
This is from a manual audit, so I didn't catch everything, and some
stuff (minor renames or things the history isn't worth linking) I left
out based on a quick scan of commit message and coarse file changes.
Signed-off-by: Brian Harring <ferringb@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pkgcore's `category_dirs` is a fossil that shouldn't be
relied upon. My recollection is this property was from
before `profiles/categories` existed, but it's just
a listdir() intersection against known directories.
PMS mandates categories be in `profiles/categories`, thus
that functionality breaks compatibility.
It will be removed from pkgcore in future semver breaks
for that reason.
Signed-off-by: Brian Harring <ferringb@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
| |
This is beyond corner case, but if someone has a non directory
in place of where a category is supposed to be, pkgcore and portage
will silently suppress this.
Pkgcore will be modified to emit a warning for this, but in the meantime,
it's a cheap check, thus add it.
Signed-off-by: Brian Harring <ferringb@gmail.com>
|