aboutsummaryrefslogtreecommitdiff
path: root/bin
diff options
context:
space:
mode:
authorSam James <sam@gentoo.org>2024-02-25 08:13:28 +0000
committerSam James <sam@gentoo.org>2024-02-25 08:15:18 +0000
commit9a06b7210562b8d03577cd4043227ea2023db1f2 (patch)
treeb51f3b12a93729456ba9ce124dd268eda4a98d5d /bin
parenttestSpawnReturnProcTerminate: Fix integer in spawn command argument (diff)
downloadportage-9a06b7210562b8d03577cd4043227ea2023db1f2.tar.gz
portage-9a06b7210562b8d03577cd4043227ea2023db1f2.tar.bz2
portage-9a06b7210562b8d03577cd4043227ea2023db1f2.zip
bin/install-qa-check.d: 90gcc-warnings: drop GCC warnings with known (heavy) FPs
Drop -Wstringop-overflow, -Wstringop-overread, -Wstringop-truncation, -Waddress, and -Wreturn-local-addr for now because they cause too many FPs. We want only reliable warnings for this Portage QA check as we encourage people to report these upstream. Bug: https://gcc.gnu.org/PR88443 Bug: https://gcc.gnu.org/PR88781 Bug: https://gcc.gnu.org/PR93644 Bug: https://gcc.gnu.org/PR97048 Bug: https://gcc.gnu.org/PR103360 Bug: https://bugs.gentoo.org/925460 Signed-off-by: Sam James <sam@gentoo.org>
Diffstat (limited to 'bin')
-rw-r--r--bin/install-qa-check.d/90gcc-warnings18
1 files changed, 12 insertions, 6 deletions
diff --git a/bin/install-qa-check.d/90gcc-warnings b/bin/install-qa-check.d/90gcc-warnings
index 449bf2362..1060618df 100644
--- a/bin/install-qa-check.d/90gcc-warnings
+++ b/bin/install-qa-check.d/90gcc-warnings
@@ -44,9 +44,12 @@ gcc_warn_check() {
# those three do not have matching -W flags, it seems
'warning: .*will always overflow destination buffer'
# compile-time part of FORTIFY_SOURCE
- 'warning: .*\[-Wstringop-overflow\]'
- 'warning: .*\[-Wstringop-overread\]'
- 'warning: .*\[-Wstringop-truncation\]'
+ # XXX: Commented out because of gcc FPs (https://gcc.gnu.org/PR88443)
+ #'warning: .*\[-Wstringop-overflow\]'
+ # XXX: Commented out because of gcc FPs (https://gcc.gnu.org/PR97048)
+ #'warning: .*\[-Wstringop-overread\]'
+ # XXX: Commented out because of gcc FPs (https://gcc.gnu.org/PR88781)
+ #'warning: .*\[-Wstringop-truncation\]'
# clang-only, equivalent of -Wstringop-overflow
'warning: .*\[-Wfortify-source\]'
'warning: .*assuming pointer wraparound does not occur'
@@ -68,7 +71,8 @@ gcc_warn_check() {
'warning: .*function.*\[-Wpointer-arith\]'
# the address of ... will never be NULL and likes
# (uses of function refs & string constants in conditionals)
- 'warning: .*\[-Waddress\]'
+ # XXX: Commented out because of gcc FPs (https://gcc.gnu.org/PR103360)
+ #'warning: .*\[-Waddress\]'
# TODO: we want to enable these but bash currently triggers
# them with a trick in random.c where it intentionally wants
@@ -95,7 +99,8 @@ gcc_warn_check() {
'warning: .*matching.*\[-Wformat=\]'
# function returns address of local variable
- 'warning: .*\[-Wreturn-local-addr\]'
+ # XXX: Commented out for bug #925460 (https://gcc.gnu.org/PR93644)
+ #'warning: .*\[-Wreturn-local-addr\]'
# missing return at end of function, or non-void return in a void function
# (clang at least aggressively optimises on this)
'warning: .*\[-Wreturn-type\]'
@@ -123,7 +128,8 @@ gcc_warn_check() {
'warning: .*\[-Wodr\]'
# warning: argument value A will result in undefined behaviour (Clang)
'warning: .*\[-Wargument-undefined-behaviour\]'
- 'warning: .*\[-Wnull-dereference\]'
+ # XXX: Commented out because of GCC FPs (https://gcc.gnu.org/PR86172)
+ #'warning: .*\[-Wnull-dereference\]'
# general sensible warnings (will be rejected by modern compilers soon)
'warning: .*\[-Wmain\]'