Incorporate review comments by Mike "vapier" Frysinger on #gentoo-dev. libusb should be slotted, emake install call was equivalent to default and udev rules are the exception to the never hardcode /lib rule.

Package-Manager: portage-2.1.11.31/cvs/Linux x86_64

3 files changed, 15 insertions, 17 deletions

diff --git a/dev-embedded/dfu-programmer/ChangeLog b/dev-embedded/dfu-programmer/ChangeLog
index 2c4ae3d29b45..f1877d546180 100644
--- a/dev-embedded/dfu-programmer/ChangeLog
+++ b/dev-embedded/dfu-programmer/ChangeLog
@@ -1,6 +1,14 @@
 # ChangeLog for dev-embedded/dfu-programmer
 # Copyright 1999-2012 Gentoo Foundation; Distributed under the GPL v2
-# $Header: /var/cvsroot/gentoo-x86/dev-embedded/dfu-programmer/ChangeLog,v 1.1 2012/11/15 12:20:19 chainsaw Exp $
+# $Header: /var/cvsroot/gentoo-x86/dev-embedded/dfu-programmer/ChangeLog,v 1.2 2012/11/15 23:17:51 chainsaw Exp $
+
+*dfu-programmer-0.5.4-r1 (15 Nov 2012)
+
+  15 Nov 2012; Tony Vroon <chainsaw@gentoo.org> -dfu-programmer-0.5.4.ebuild,
+  +dfu-programmer-0.5.4-r1.ebuild:
+  Incorporate review comments by Mike "vapier" Frysinger on #gentoo-dev. libusb
+  should be slotted, emake install call was equivalent to default and udev
+  rules are the exception to the never hardcode /lib rule.
 
 *dfu-programmer-0.5.4 (15 Nov 2012)
 
diff --git a/dev-embedded/dfu-programmer/Manifest b/dev-embedded/dfu-programmer/Manifest
index 1971feb7f3e7..12d425bdb7b7 100644
--- a/dev-embedded/dfu-programmer/Manifest
+++ b/dev-embedded/dfu-programmer/Manifest
@@ -1,15 +1,5 @@
------BEGIN PGP SIGNED MESSAGE-----
-Hash: SHA256
-
 AUX 0.5.4-as-needed.patch 540 SHA256 863c51799d26e9dc784ff92e3b88bf69e1b19a5e6ddd22375e27782b25c9c4b1 SHA512 17bcb1fae69ec109ad94eed79a8b981b3f6753856a9c5a25843f7d5fb3420774434f30a2db37326a85be575d019cf652e4a7d726635dd48e0617240b2c79aa55 WHIRLPOOL 2087d7f90b7f8422761ee5f42a201c9ba757ab2da5c3b0a282398924b8cf3fb654d3b84d63798686ded64433d05718fb6cfbf94224b2ee5b875bbb66794a0d73
 DIST dfu-programmer-0.5.4.tar.gz 126700 SHA256 c0fb08fead3d4379368d0e4af5a5aa99c7acee32fa8696cd3e27d2f7856a20de SHA512 c6e0000e7d849144ff4d9191b09540f6a7c7414221952b26898421622079c1fd300e1a4d0f35db6f867e539f59c129850c6a9c745bc0f9916723e8e89fe2fd63 WHIRLPOOL bd8f7c6831544209e4513bd4231e4e1f6f43fadff05d319c22551d8cc99e1b0b5b0b98515175baaf3cf8e6baf79ff140b714f314f39063a80583dcce6dec7404
-EBUILD dfu-programmer-0.5.4.ebuild 1234 SHA256 c6b18282a683f699ca0b7af08eedc497bbc8173ce9978b21ca825bfde0f438ca SHA512 ec26f365b16fd8eca653627da2f27c74093a1a621e364022c08a89156481bea69bfae55cea8f1acf737eb13c9b678dcd1eb16197d4a12c12a69bde8696c97d1e WHIRLPOOL d544b4d9e6064b0ade470cd7143269284fa7f09eb0f54319dc356530b98bf7f18de84772c1dba7e241e459dec773ae78088b90b3dd54e14b6cc776b9f322cfc6
-MISC ChangeLog 532 SHA256 8e7863b87440396958f009842830e874cf9fca6df52cd5b30c84e5c9b00a69af SHA512 3ea4ef4cda1ee889f677fc87d6f5e084caf389d701b88eb13f208edf425466c817b48fcdb50912ef08ad6ee9ab4af4070d901778ae7caa70b583ae44bb21e063 WHIRLPOOL c3aa94a197216998e75cc08823bcf0732eb764ab7db2909302d08b1213018ab3540e654d49b52130cc43f59d3a1f9cd96df0b444d98cfe1f59a1ba6b5c627dd1
+EBUILD dfu-programmer-0.5.4-r1.ebuild 1230 SHA256 02c90c450299fa9dd4409334afb85a1838db3fe607c762d1f26269eca9131ab6 SHA512 07a583f39789af38c7d66c63c5ce87e379c90ded165fa60a7928a082c82100a3c2f67f156aecdf6b85409c1952637c6dc8fe82e427de942b887d1b11726f183a WHIRLPOOL dfca47d4422c5e90a32a944d367d5314b0447efe584691683a7cd77ac63987979406ab9f36fbfed75f6b54f93bb14da2c7945a2f2ec2c93b1d7b771b1fd39a20
+MISC ChangeLog 900 SHA256 6f2b7fb38f456e09f077d35db09134e43e2c164575ffa1095dfb953a870fe342 SHA512 f0b16d9ff57edc1d12f63c8878b983fe950e6401384b9b6783414d8fc0f006becf2352f8b5845959bc44bf43b13250d7ebe677d9b5fdda70a8c58f87177f046a WHIRLPOOL f9a99cd2db47f7d331f10b55ea525f925fde83045e49909f392fc3bed23414020d2b520efcfe9c57411a7397b9c272d898fb2a8c3ae16cf924c2f2827a47e642
 MISC metadata.xml 261 SHA256 9c0eae44725911a5c650cf6391e799c23c5398ab6117c76c39d7cf13dcf000fd SHA512 a00584b13ef67640b01375f1ebefc0f0604b206d90d759105eaaa2da600883d65e80724df5921635f27c8b10252fdd0412c1760137211aec1e4f1f997c4acece WHIRLPOOL 777ebc104c88ea399a68d128a03db87570f37d09a6ace615cb1463f85b999f15de05371e9440a06f914f0c0339da7224fe0219165dd4c4b90663df93573b201b
------BEGIN PGP SIGNATURE-----
-Version: GnuPG v2.0.19 (GNU/Linux)
-
-iEYEAREIAAYFAlCk3iUACgkQp5vW4rUFj5qchQCgqTzUE90aSrURFZyz6Ri3REPD
-FpUAn3MC2S6QhgjfwsToi4dV4Gb+G61l
-=SnzP
------END PGP SIGNATURE-----
diff --git a/dev-embedded/dfu-programmer/dfu-programmer-0.5.4.ebuild b/dev-embedded/dfu-programmer/dfu-programmer-0.5.4-r1.ebuild
index 864f56aa45ec..035098f88298 100644
--- a/dev-embedded/dfu-programmer/dfu-programmer-0.5.4.ebuild
+++ b/dev-embedded/dfu-programmer/dfu-programmer-0.5.4-r1.ebuild
@@ -1,6 +1,6 @@
-# Copyright 2012-2012 Gentoo Foundation
+# Copyright 1999-2012 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/dev-embedded/dfu-programmer/dfu-programmer-0.5.4.ebuild,v 1.1 2012/11/15 12:20:19 chainsaw Exp $
+# $Header: /var/cvsroot/gentoo-x86/dev-embedded/dfu-programmer/dfu-programmer-0.5.4-r1.ebuild,v 1.1 2012/11/15 23:17:51 chainsaw Exp $
 
 EAPI=4
 inherit autotools base
@@ -13,7 +13,7 @@ SLOT="0"
 KEYWORDS="~amd64"
 IUSE=""
 
-DEPEND="virtual/libusb
+DEPEND="virtual/libusb:1
 	sys-fs/udev"
 RDEPEND="${DEPEND}"
 PATCHES=( "${FILESDIR}/${PV}-as-needed.patch" )
@@ -26,7 +26,7 @@ src_prepare() {
 src_install() {
 	emake DESTDIR="${D}" install || die "make install failed"
 	ebegin "Generating UDEV rules..."
-	UDEV_RULES="$(get_libdir)/udev/rules.d/70-dfu-programmer.rules"
+	UDEV_RULES="/lib/udev/rules.d/70-dfu-programmer.rules"
 	mkdir -p "${D}"/${UDEV_RULES%/*}
 	echo -e "#\n# do not edit this file, it will be overwritten on update\n#" \
 		> "${D}"/${UDEV_RULES}