summaryrefslogtreecommitdiff
path: root/eclass
diff options
context:
space:
mode:
authorRobin H. Johnson <robbat2@gentoo.org>2020-03-07 11:54:46 -0800
committerRobin H. Johnson <robbat2@gentoo.org>2020-03-07 12:02:10 -0800
commit1b302a4d9361b070f0ace9547b1faa5b0cf5da89 (patch)
tree6340c556c1c6fee2cf864d86632f658624b3c5ed /eclass
parentsys-fs/mergerfs-2.28.3-r1: amd64 stable (bug 711814) (diff)
downloadgentoo-1b302a4d9361b070f0ace9547b1faa5b0cf5da89.tar.gz
gentoo-1b302a4d9361b070f0ace9547b1faa5b0cf5da89.tar.bz2
gentoo-1b302a4d9361b070f0ace9547b1faa5b0cf5da89.zip
go-module: workaround MissingUnpackerDep QA false positive
The go.sum behavior in this eclass triggers a false positive from pkgcheck, specifically: MissingUnpackerDep: version ...: missing BDEPEND="app-arch/unzip" The eclass & package do NOT invoke any direct unpacking of the zipfiles, and leave that entirely to Go's builtin code, making app-arch/unzip completely unneeded. Adding packages using the new eclass functionality will spam the above MissingUnpackerDep warning, so workaround it for now, until pkgcheck/QA can not give the false positive. Reference: https://github.com/pkgcore/pkgcheck/issues/214 Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
Diffstat (limited to 'eclass')
-rw-r--r--eclass/go-module.eclass6
1 files changed, 6 insertions, 0 deletions
diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass
index 08c123873c47..cdd5b07a930f 100644
--- a/eclass/go-module.eclass
+++ b/eclass/go-module.eclass
@@ -57,6 +57,12 @@ _GO_MODULE=1
BDEPEND=">=dev-lang/go-1.12"
+# Workaround for pkgcheck false positive: https://github.com/pkgcore/pkgcheck/issues/214
+# MissingUnpackerDep: version ...: missing BDEPEND="app-arch/unzip"
+# Added here rather than to each affected package, so it can be cleaned up just
+# once when pkgcheck is improved.
+BDEPEND+=" app-arch/unzip"
+
# Force go to build in module mode.
# In this mode the GOPATH environment variable is ignored.
# this will become the default in the future.